Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump geth to v1.15.0 #16369

Merged
merged 8 commits into from
Feb 18, 2025
Merged

bump geth to v1.15.0 #16369

merged 8 commits into from
Feb 18, 2025

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Feb 13, 2025

It looks like params.Version was removed, so we will have to find a work around.

jmank88 and others added 3 commits February 12, 2025 18:15
core/gethwrappers: replace removed params.Version; make generate
@jmank88 jmank88 mentioned this pull request Feb 13, 2025
Copy link
Contributor

Flakeguard Summary

Ran new or updated tests between develop and ba56837 (geth-1.15.0).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

1 Results
Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestCheckContractHashesFromLastGoGenerate 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/gethwrappers false 0s Unknown

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

Copy link
Contributor

github-actions bot commented Feb 13, 2025

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@jmank88 jmank88 marked this pull request as ready for review February 13, 2025 01:20
@jmank88 jmank88 requested review from a team as code owners February 13, 2025 01:20
@jmank88 jmank88 requested a review from Atrax1 February 13, 2025 01:20
@jmank88 jmank88 enabled auto-merge February 13, 2025 01:20
@jmank88 jmank88 requested a review from AnieeG February 13, 2025 01:23
@reductionista
Copy link
Contributor

Looks good, aside from the compatibility test errors. It's having trouble binding to port 8080. I see a test added to geth in November that references port 8080, but it doesn't look like they are binding to it or anything... just translating addresses 🤔
ethereum/go-ethereum@ae83912#diff-97204dc819479e38281c8298010175c48bbb203f7cbf871566f395902a6f928dR32-R68

@jmank88 jmank88 requested a review from krehermann February 13, 2025 01:38
pavel-raykov
pavel-raykov previously approved these changes Feb 13, 2025
krehermann
krehermann previously approved these changes Feb 13, 2025
@jmank88 jmank88 requested a review from samsondav February 13, 2025 19:29
pavel-raykov
pavel-raykov previously approved these changes Feb 14, 2025
@jmank88
Copy link
Contributor Author

jmank88 commented Feb 14, 2025

Conflicts resolved. Please re-approve 🙏

alecgard
alecgard previously approved these changes Feb 14, 2025
reductionista
reductionista previously approved these changes Feb 15, 2025
@pavel-raykov pavel-raykov dismissed stale reviews from reductionista, alecgard, and themself via 043ae3f February 18, 2025 13:05
@jmank88 jmank88 added this pull request to the merge queue Feb 18, 2025
github-merge-queue bot pushed a commit that referenced this pull request Feb 18, 2025
* bump geth to v1.14.13

core/gethwrappers: replace removed params.Version; make generate

* Run make generate

* bump geth v1.15.0

* make generate

* Minor

* Minor

---------

Co-authored-by: Sam Davies <[email protected]>
Co-authored-by: AnieeG <[email protected]>
Co-authored-by: pavel-raykov <[email protected]>
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 18, 2025
@pavel-raykov pavel-raykov added this pull request to the merge queue Feb 18, 2025
Merged via the queue into develop with commit e386c17 Feb 18, 2025
303 of 334 checks passed
@pavel-raykov pavel-raykov deleted the geth-1.15.0 branch February 18, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.