[CAPPL-442] add workflow registry view #16336
Conversation
eutopian
requested review from
winder,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara,
0xAustinWang and
0xnogo
eutopian
force-pushed
the
CAPPL-442/workflow-registry-views
branch
2 times, most recently
from
5fd521e to
c39061c
Compare
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
| config: | ||
| dir: common/view/v1_0/mocks/ | ||
| filename: workflow_registry_interface.go |
There was a problem hiding this comment.
Just for my knowledge, this generated interface is just for testing as in mocks.WorkflowRegistryInterface. I see we are using the wrapper workflow_registry "github.com/smartcontractkit/chainlink/v2/core/gethwrappers/workflow/generated/workflow_registry_wrapper" in workflowreg.go.
eutopian
force-pushed
the
CAPPL-442/workflow-registry-views
branch
2 times, most recently
from
c7f649b to
901f8da
Compare
| @@ -1,5 +1,5 @@ | |||
| golang 1.23.3 | |||
| mockery 2.46.3 | |||
| mockery 2.50.0 | |||
There was a problem hiding this comment.
recently bumped
Line 163 in 8df2e65
| for { | ||
| wmds, err := wr.GetWorkflowMetadataListByDON(nil, donID, start, pageSize) | ||
| if err != nil { | ||
| return WorkflowRegistryView{}, fmt.Errorf("GetWorkflowMetadataListByDON failed for donID %d: %w", donID, err) |
There was a problem hiding this comment.
consider whether you want these errors to really abort the view. almost certainly better to defined and return error types for the caller.
learned the hard way as the recent state view problem convinced me it's better to aggregrate non-fatal errors and return them to the caller to handle so that, at least in principle, a failure in the this part (the WFR view) doesn't block all other state
eg
chainlink/deployment/environment.go
Line 388 in f84bbe0
There was a problem hiding this comment.
Makes sense from a view perspective; makes me think of gql requests where individual fields that errors during a request doesn't cause the entire call to error but instead you get partial data for all the fields it was able to resolve and an array of errors for each field that it wasn't able to process.
eutopian
force-pushed
the
CAPPL-442/workflow-registry-views
branch
2 times, most recently
from
eebd640 to
e0e248b
Compare
eutopian
force-pushed
the
CAPPL-442/workflow-registry-views
branch
from
e0e248b to
b656fcf
Compare
|
* add workflow registry view * print instead of return from registry errors [CAPPL-442] add workflow registry view (#16336) * add workflow registry view * print instead of return from registry errors Added commit price only method config to Solana ChainWriter (#16401) * Added commit price only method config to Solana ChainWriter * Moved ATA config from commit method to execute * Upgraded chainlink-ccip dependency * Addressed feedback refactor extradata codec to unblock ccip ocr message optimization using protobuf (#16402) * refactor extradata codec to unblock ccip ocr message optimization using protobuf * goimport * revert * minor * minor * refactor * fix import * fix import * add comments * fix test * support Solana->EVM * fix * update * fix make [NONEVM-1319] - Solana Contract Reader Dest and Source cfg (#16308) * Implement Solana Contract Reader config and bump chainlink-solana * Update CR config * Resolve more TODOs from Contract Reader config * Bump solana * Progress on CR config * Add comments to CR config * Bump chainlink-ccip/chains/solana in core too * Use feeQuoterIDL * Fix CR config issues * Simplify CR config and add a TODO * Remove CR config resolved TODOs and add serialisation test * Add MethodNameOffRampLatestConfigDetails to CR config * Fix cfg * Upgraded chainlink-common dependency * Bump common and resolve OffRampLatestConfigDetails issues * Fixed linting --------- Co-authored-by: Blaž Hrastnik <[email protected]> Co-authored-by: amit-momin <[email protected]> Add new RMN smoke test (#16385) * Add new RMN smoke test * Fix linting issues [TT-1991] use github.sha in integration-tests workflow (#16396) * use github.sha in integration-tests workflow * more Slack message debug * use reusable workflow sha from main branch TT-1956 Add support for e2e docker tests in Flakeguard #16376 (#16380) * Bump Flakeguard * wip * update test * update test cmd * bump * bump * bump * bump * fix * bump * fix * bump * bump * bump * bump * fail test * bump * Run nightly workflow with flakeguard * bump * bump * Add extraArgs input to E2E tests workflow for customizable arguments * bump * bump * bump * bump * Add extraArgs input to nightly E2E tests workflow for customizable arguments * bump * bump * bump * bump * bump * revert tests * bump * bump * bump * bump * bump * bump * bump * trigger tests * Revert "trigger tests" This reverts commit dbb37c4. fix: restore files go mod
Requires
Supports