Updates to deploy CCIP Solana to staging

[jlaveracll]

Requires

Supports

[github-actions]

AER Report: CI Core

aer_workflow , commit , Clean Go Tidy & Generate , Scheduled Run Frequency , Detect Changes , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , test-scripts , GolangCI Lint (deployment) , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , lint , SonarQube Scan

1. Error return value of syscall.Kill is not checked: [Golang Lint (deployment)]

Source of Error:

deployment/solana_chain.go:159:16: Error return value of `syscall.Kill` is not checked (errcheck)
			syscall.Kill(-pgid, syscall.SIGTERM)
			 ^

Why: The syscall.Kill function call does not check for an error return value, which can lead to unhandled errors and potential issues in the program's execution.

Suggested fix: Add error handling for the syscall.Kill function call to ensure any errors are properly managed.

2. Error return value of cmd.Process.Kill is not checked: [Golang Lint (deployment)]

Source of Error:

deployment/solana_chain.go:161:19: Error return value of `cmd.Process.Kill` is not checked (errcheck)
		cmd.Process.Kill()
		 ^

Why: The cmd.Process.Kill function call does not check for an error return value, which can lead to unhandled errors and potential issues in the program's execution.

Suggested fix: Add error handling for the cmd.Process.Kill function call to ensure any errors are properly managed.

3. fmt.Errorf can be replaced with errors.New: [Golang Lint (deployment)]

Source of Error:

deployment/solana_chain.go:162:14: fmt.Errorf can be replaced with errors.New (perfsprint)
		return "", fmt.Errorf("deployment timed out after 5 minutes")
		 ^

Why: The fmt.Errorf function is used where errors.New would be more appropriate, as no formatting is required.

Suggested fix: Replace fmt.Errorf with errors.New for better performance and readability.

4. fmt.Errorf can be replaced with errors.New: [Golang Lint (deployment)]

Source of Error:

deployment/common/changeset/deploy_link_token.go:124:10: fmt.Errorf can be replaced with errors.New (perfsprint)
		return fmt.Errorf("deployer key must be set")
		 ^

Why: The fmt.Errorf function is used where errors.New would be more appropriate, as no formatting is required.

Suggested fix: Replace fmt.Errorf with errors.New for better performance and readability.

5. Issues found: [Golang Lint (deployment)]

Source of Error:

##[error]issues found

Why: The GolangCI Lint found issues in the code that need to be addressed.

Suggested fix: Review and fix the issues reported by GolangCI Lint to ensure code quality and compliance with best practices.

6. At least one 'GolangCI Lint' matrix job failed: [Check Golangci-lint Matrix Results]

Source of Error:

Check Golangci-lint Matrix Results	2025-02-07T15:52:29.1665106Z ##[error]Process completed with exit code 1.

Why: The GolangCI Lint job failed due to the issues found in the code.

Suggested fix: Address the issues reported by GolangCI Lint and re-run the job to ensure it passes successfully.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

[cl-sonarqube-production]

Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarQube IDE