Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solana ccip contract split #16159

Merged
merged 46 commits into from
Feb 10, 2025
Merged

solana ccip contract split #16159

merged 46 commits into from
Feb 10, 2025

Conversation

yashnevatia
Copy link
Contributor

Requires

Supports

@yashnevatia yashnevatia requested review from a team, AnieeG and kylesmartin as code owners January 30, 2025 21:34
@yashnevatia yashnevatia changed the base branch from develop to solana-token-pool January 30, 2025 21:34
Copy link
Contributor

github-actions bot commented Jan 30, 2025

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@yashnevatia yashnevatia requested a review from a team as a code owner January 31, 2025 09:52
Base automatically changed from solana-token-pool to develop January 31, 2025 10:23
@tt-cll tt-cll force-pushed the deploy-transferable-solana branch 2 times, most recently from 7b747f8 to 527bd52 Compare February 1, 2025 15:19
@tt-cll tt-cll force-pushed the deploy-transferable-solana branch from 05e7ee7 to ceaadeb Compare February 3, 2025 09:01
@@ -0,0 +1,88 @@
package solana
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we split cs_chain_contracts.go to smaller files, this is one of them

@@ -0,0 +1,257 @@
package solana
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we split cs_chain_contracts.go to smaller files, this is one of them

@@ -0,0 +1,381 @@
package solana
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we split cs_chain_contracts.go to smaller files, this is one of them

archseer
archseer previously approved these changes Feb 10, 2025
@archseer archseer enabled auto-merge February 10, 2025 13:44
ecPablo
ecPablo previously approved these changes Feb 10, 2025
Copy link
Contributor

@ecPablo ecPablo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left some minor comments but feel free to change in a followup as they are not blocking IMO

// for PDAs from AddRemoteChainToSolana
RemoteSource deployment.ContractType = "RemoteSource"
RemoteDest deployment.ContractType = "RemoteDest"

// Tokenpool lookup table
TokenPoolLookupTable deployment.ContractType = "TokenPoolLookupTable"
)

// SolChainState holds a Go binding for all the currently deployed CCIP programs
// on a chain. If a binding is nil, it means here is no such contract on the chain.
type SolCCIPChainState struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a different PR: can this be moved into the solana folder as solana/state.go?

Copy link
Contributor Author

@yashnevatia yashnevatia Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this unfortunately is going to create some nasty import cycles.
same reason why i am not being able to move a lot of solana code from cs_deploy_chain.go

@yashnevatia yashnevatia dismissed stale reviews from ecPablo and archseer via 849eec2 February 10, 2025 15:36
archseer
archseer previously approved these changes Feb 10, 2025
makramkd
makramkd previously approved these changes Feb 10, 2025
@archseer archseer added this pull request to the merge queue Feb 10, 2025
Merged via the queue into develop with commit cb77616 Feb 10, 2025
208 of 211 checks passed
@archseer archseer deleted the deploy-transferable-solana branch February 10, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants