-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solana ccip contract split #16159
solana ccip contract split #16159
Conversation
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
7b747f8
to
527bd52
Compare
05e7ee7
to
ceaadeb
Compare
@@ -0,0 +1,88 @@ | |||
package solana |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we split cs_chain_contracts.go to smaller files, this is one of them
@@ -0,0 +1,257 @@ | |||
package solana |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we split cs_chain_contracts.go to smaller files, this is one of them
@@ -0,0 +1,381 @@ | |||
package solana |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we split cs_chain_contracts.go to smaller files, this is one of them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Left some minor comments but feel free to change in a followup as they are not blocking IMO
// for PDAs from AddRemoteChainToSolana | ||
RemoteSource deployment.ContractType = "RemoteSource" | ||
RemoteDest deployment.ContractType = "RemoteDest" | ||
|
||
// Tokenpool lookup table | ||
TokenPoolLookupTable deployment.ContractType = "TokenPoolLookupTable" | ||
) | ||
|
||
// SolChainState holds a Go binding for all the currently deployed CCIP programs | ||
// on a chain. If a binding is nil, it means here is no such contract on the chain. | ||
type SolCCIPChainState struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a different PR: can this be moved into the solana
folder as solana/state.go
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this unfortunately is going to create some nasty import cycles.
same reason why i am not being able to move a lot of solana code from cs_deploy_chain.go
…kit/chainlink into deploy-transferable-solana
|
Requires
Supports