Extend ChangesetOutput to include a list of ProposedJobs

[cgruber]

Extend ChangesetOutput to include a ProposedJobs slice, which contains the job spec, the node id, and the job id (as returned from the propose API of JD). Also, mark JobSpecs as deprecated. Once we remove all JobSpecs use, we can remove that field.

DPA-1518

[AnieeG]

is this the NodeId returned by JD?

[cgruber]

It's whatever node was going to be used in the existing code - I believe JobSpec right now is indexed by node. That one.

[github-actions]

AER Report: CI Core

aer_workflow , commit , Clean Go Tidy & Generate , Detect Changes , Scheduled Run Frequency , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_fuzz) , GolangCI Lint (deployment) , Core Tests (go_core_race_tests) , test-scripts , lint , SonarQube Scan

1. Empty block in code: Golang Lint (deployment)

Source of Error:

Golang Lint (deployment)	2025-01-30T18:09:37.8759239Z ##[error]deployment/common/changeset/test_helpers.go:71:22: empty-block: this block is empty, you can remove it (revive)
Golang Lint (deployment)	2025-01-30T18:09:37.8759970Z 		if out.Jobs != nil {
Golang Lint (deployment)	2025-01-30T18:09:37.8760229Z 			// do nothing, as these jobs auto-accept.
Golang Lint (deployment)	2025-01-30T18:09:37.8761051Z 		}

Why: The linter detected an empty block in the code, which is generally considered bad practice as it can lead to confusion and maintenance issues.

Suggested fix: Remove the empty block or add meaningful code inside the block if it is necessary for future logic.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

[cl-sonarqube-production]

Quality Gate passed

Issues
3 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube