CCIP-4566 token pool views #16116
CCIP-4566 token pool views #16116
Conversation
bukata-sa
requested review from
AnieeG,
kylesmartin and
a team
as code owners
bukata-sa
requested review from
winder,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara,
0xAustinWang and
0xnogo
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
There was a problem hiding this comment.
There are some additional fields that we should capture for USDC and LockRelease:
LockRelease: acceptLiquidity, rebalancer
USDC: domains, messageTransmitter, tokenMessenger
Maybe worth having three separate views?
- All burn mint types (burn mint, burn from mint, burn with from mint, etc.)
- Lock release
- USDC
| "github.com/smartcontractkit/chainlink/deployment/common/view/types" | ||
| ) | ||
|
|
||
| type TokenPoolContract interface { |
There was a problem hiding this comment.
This is technically the interface for v1_5_1, package name should be updated as there are breaking changes between v1_5 and v1_5_1
There was a problem hiding this comment.
Also, add comment for interface & maybe link here: https://github.com/smartcontractkit/chainlink/blob/develop/core/gethwrappers/ccip/generated/token_pool/token_pool.go
So it is clear where these methods are coming from.
| type RemoteChainConfig struct { | ||
| // RemoteTokenAddress is a hex representation of byte arrays | ||
| RemoteTokenAddress string | ||
| // RemotePoolAddresses are a hex representations of byte arrays | ||
| RemotePoolAddresses []string | ||
| } |
There was a problem hiding this comment.
| type RemoteChainConfig struct { | |
| // RemoteTokenAddress is a hex representation of byte arrays | |
| RemoteTokenAddress string | |
| // RemotePoolAddresses are a hex representations of byte arrays | |
| RemotePoolAddresses []string | |
| } | |
| type RemoteChainConfig struct { | |
| // RemoteTokenAddress is the address of the token on the remote chain. | |
| RemoteTokenAddress []common.Address | |
| // RemotePoolAddresses are the addresses of valid token pools on the remote chain. | |
| RemotePoolAddresses []common.Address | |
| // InboundRateLimiterConfig is the rate limiter config for inbound transfers from the remote chain. | |
| InboundRateLimterConfig token_pool.RateLimiterConfig | |
| // OutboundRateLimiterConfig is the rate limiter config for outbound transfers to the remote chain. | |
| OutboundRateLimiterConfig token_pool.RateLimiterConfig | |
| } |
There was a problem hiding this comment.
I didn't put common.Address here intentionally, as we don't know what length will be these byte arrays
Switched back from hex to []byte
| type TokenPoolView struct { | ||
| types.ContractMetaData | ||
| Token common.Address `json:"token"` | ||
| RemoteChainConfigs map[uint64]RemoteChainConfig `json:"remoteChainConfigs"` |
There was a problem hiding this comment.
"SupportedChains" aligns with convention of the contract
| RemoteChainConfigs map[uint64]RemoteChainConfig `json:"remoteChainConfigs"` | |
| SupportedChains map[uint64]RemoteChainConfig `json:"supportedChains"` |
There was a problem hiding this comment.
No, SupportedChains is another methods+field on the contract
remoteChainConfigs doesn't have public method, but corresponds to s_remoteChainConfigs internal field
| } | ||
| remotePoolsHex := make([]string, len(remotePools)) | ||
| for i, remotePool := range remotePools { | ||
| remotePoolsHex[i] = hex.EncodeToString(remotePool) |
There was a problem hiding this comment.
Can just use common.BytesToAddress() if you change the remote address fields to use common.Address
There was a problem hiding this comment.
I didn't put common.Address here intentionally, as we don't know what length will be these byte arrays
Switched back from hex to []byte
|
CCIP 1.5/1.6 Token pool views