INTAUTO-306 Add ccip message assertions e2e tests #16107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaoluisam
requested review from
winder,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara,
0xAustinWang and
0xnogo
kalverra
requested changes
Jan 28, 2025
kalverra
previously approved these changes
Jan 28, 2025
matYang
reviewed
Jan 28, 2025
contracts/src/v0.8/ccip/test/helpers/receivers/MaybeRevertMessageReceiver.sol
Outdated
Show resolved
Hide resolved
contracts/src/v0.8/ccip/test/helpers/receivers/MaybeRevertMessageReceiver.sol
Show resolved
Hide resolved
contracts/src/v0.8/ccip/test/helpers/receivers/MaybeRevertMessageReceiver.sol
Outdated
Show resolved
Hide resolved
matYang
previously approved these changes
Jan 29, 2025
|
kalverra
approved these changes
Jan 30, 2025
b-gopalswami
approved these changes
Jan 30, 2025
matYang
approved these changes
Jan 30, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
simsonraj
deleted the
INTAUTO-306_Add_ccip_message_assertions_e2e_tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to the
MaybeRevertMessageReceivercontract and related integration tests. The most important changes are the addition of new events and error handling in the contract, the ability for the manager to withdraw funds and tokens, and enhancements to the integration tests to handle these updates.Contract Enhancements:
contracts/src/v0.8/ccip/test/helpers/receivers/MaybeRevertMessageReceiver.sol: Added new events (FundsWithdrawn,TokensWithdrawn, and a detailedMessageReceived), new errors (Unauthorized,InsufficientBalance, andTransferFailed), and functions to withdraw Ether and ERC-20 tokens. The manager can now withdraw funds and tokens, and theccipReceivefunction emits a detailedMessageReceivedevent. [1] [2] [3]Integration Test Updates:
integration-tests/ccip-tests/actions/ccip_helpers.go: Updated theSendRequestfunction to return message data, added aMessageReceivedWatcherto theDestCCIPModule, and implemented theAssertMessageContentMatchfunction to validate message content. These changes ensure that the integration tests can handle the new contract events and validate message content. [1] [2] [3]Additional Changes:
core/gethwrappers/ccip/generation/generated-wrapper-dependency-versions-do-not-edit.txt: Updated the ABI and binary references for theMaybeRevertMessageReceivercontract.integration-tests/ccip-tests/actions/ccip_helpers.go: Added the import for themaybe_revert_message_receiverpackage. (F9d51ed8L9R9)contracts/.changeset/smart-bats-repair.md: Documented the update to theMaybeRevertMessageReceivercontract to emit the message received event and allow token withdrawal.