Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USDC token pool changesets (+ token pool patches) #16062

Closed
wants to merge 83 commits into from
Closed

Conversation

kylesmartin
Copy link
Contributor

@kylesmartin kylesmartin commented Jan 24, 2025

https://smartcontract-it.atlassian.net/browse/CCIP-4507

This PR adds two new changesets:

  • DeployUSDCTokenPoolContractsChangeset: Deploys USDC token pools on given chains
  • SyncUSDCDomainsWithChainsChangeset: Syncs USDC domain support with supported chains

It also makes a few patches to token pool utilities and changesets:

  • Replaces references to deployment.Version1_5_1 with CurrentTokenPoolVersion to make updating the token pool version easier (This assumes that the API won't break though, a better approach to versioning is still needed long term)
  • Fixes a bug in ConfigureTokenPoolContractsChangeset where we were validating ownership of the token admin registry rather than the relevant token pool
  • Always check for existence of timelock, required for ownership check even if MCMS is not used
  • Add check in deployer group, specifically enactMCMS, for 0 transactions (expected if there is nothing to do)

Requires

#16140

@kylesmartin kylesmartin requested review from a team as code owners February 4, 2025 15:19
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Solidity Review Jira issue

Hey! We have taken the liberty to link this PR to a Jira issue for Solidity Review.

This is a new feature, that's currently in the pilot phase, so please make sure that the linkage is correct. In a contrary case, please update it manually in JIRA and replace Solidity Review issue key in the changeset file with the correct one.
Please reach out to the Test Tooling team and notify them about any issues you encounter.

Any changes to the Solidity Review Jira issue should be reflected in the changeset file. If you need to update the issue key, please do so manually in the following changeset file: contracts/.changeset/brave-keys-enjoy.md

This PR has been linked to Solidity Review Jira issue: CCIP-3966

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Static analysis results are available

Hey @kylesmartin, you can view Slither reports in the job summary here or download them as artifact here.
Please check them before merging and make sure you have addressed all issues.

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Flakeguard Summary

Ran new or updated tests between develop and 6edaa5a (CCIP-4507).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestEmptyBatch 66.67% true true false 3 2 1 0 github.com/smartcontractkit/chainlink/deployment/ccip/changeset true 8.095s @AnieeG, @kylesmartin, @smartcontractkit/ccip-offchain, @smartcontractkit/deployment-automation
TestSmokeState 0.00% true true false 2 0 2 0 github.com/smartcontractkit/chainlink/deployment/ccip/changeset true 0s @AnieeG, @kylesmartin, @smartcontractkit/ccip-offchain, @smartcontractkit/deployment-automation

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

@kylesmartin kylesmartin changed the base branch from develop to CCIP-4748_cctp-upgradeability-fix February 4, 2025 17:10
@cl-sonarqube-production
Copy link

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Flakeguard Summary

Ran new or updated tests between CCIP-4748_cctp-upgradeability-fix and 240fc25 (CCIP-4507).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestSmokeState 0.00% true true false 3 0 3 0 github.com/smartcontractkit/chainlink/deployment/ccip/changeset true 0s @AnieeG, @kylesmartin, @smartcontractkit/ccip-offchain, @smartcontractkit/deployment-automation

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

@kylesmartin kylesmartin changed the base branch from CCIP-4748_cctp-upgradeability-fix to develop February 14, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants