[TT-1847] ocr3 keystone por test broken 2 - WIP, DO NOT REVIEW

[Tofel]

Requires

Supports

[cl-sonarqube-production]

Quality Gate passed

Issues
0 New issues
6 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

[github-actions]

AER Report: CI Core

aer_workflow , commit , Clean Go Tidy & Generate , Detect Changes , Scheduled Run Frequency , GolangCI Lint (.) , Core Tests (go_core_tests) , GolangCI Lint (integration-tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , test-scripts , lint , SonarQube Scan

1. GolangCI Lint errors: Golang Lint (integration-tests)

Source of Error:

integration-tests/capabilities/workflow_test.go:628:51: commentFormatting: put a space between `//` and comment text (gocritic)
integration-tests/capabilities/workflow_test.go:424:15: G107: Potential HTTP request made with variable url (gosec)
integration-tests/capabilities/workflow_test.go:520:9: G204: Subprocess launched with a potential tainted input or cmd arguments (gosec)
integration-tests/capabilities/workflow_test.go:863:18: G204: Subprocess launched with a potential tainted input or cmd arguments (gosec)
integration-tests/capabilities/workflow_test.go:1260:2: Consider pre-allocating `hashedCapabilities` (prealloc)
integration-tests/capabilities/workflow_test.go:1255:2: Consider pre-allocating `nopsToAdd` (prealloc)
integration-tests/capabilities/workflow_test.go:1256:2: Consider pre-allocating `nodesToAdd` (prealloc)
integration-tests/capabilities/workflow_test.go:1257:2: Consider pre-allocating `donNodes` (prealloc)
integration-tests/capabilities/workflow_test.go:1258:2: Consider pre-allocating `signers` (prealloc)
integration-tests/capabilities/workflow_test.go:1312:2: Consider pre-allocating `capRegConfig` (prealloc)
integration-tests/capabilities/workflow_test.go:201:7: var-naming: var assetId should be assetID (revive)
integration-tests/capabilities/workflow_test.go:467:2: var-naming: struct field DonId should be DonID (revive)
integration-tests/capabilities/workflow_test.go:493:6: var-naming: type Rpc should be RPC (revive)
integration-tests/capabilities/workflow_test.go:785:3: var-naming: don't use underscores in Go names; var workflow_registryInstance should be workflowRegistryInstance (revive)
integration-tests/capabilities/workflow_test.go:839:7: var-naming: var workflowGistUrl should be workflowGistURL (revive)
integration-tests/capabilities/workflow_test.go:840:7: var-naming: var workflowConfigUrl should be workflowConfigURL (revive)
integration-tests/capabilities/workflow_test.go:844:4: var-naming: var feedId should be feedID (revive)
integration-tests/capabilities/workflow_test.go:403:25: unnecessary conversion (unconvert)
integration-tests/capabilities/workflow_test.go:225:2: unnecessary trailing newline (whitespace)
integration-tests/capabilities/workflow_test.go:917:84: fmt.Sprintf can be replaced with string concatenation (perfsprint)

Why: The errors are due to various issues detected by the GolangCI Lint tool, including improper comment formatting, potential security vulnerabilities, inefficient memory allocation, improper variable naming, unnecessary conversions, and formatting issues.

Suggested fix: Address each linting issue as follows:

• Add a space between // and comment text.
• Avoid using variable URLs directly in HTTP requests.
• Ensure subprocess commands are not using tainted inputs.
• Pre-allocate slices where suggested.
• Follow Go naming conventions for variables and types.
• Remove unnecessary type conversions and trailing newlines.
• Replace fmt.Sprintf with string concatenation where applicable.

2. Go Tidy & Generate error: Clean Go Tidy & Generate

Source of Error:

make generate	2025-01-24T11:20:10.3025333Z 	go: updates to go.mod needed; to update it:
make generate	2025-01-24T11:20:10.3025421Z 		go mod tidy
make generate	2025-01-24T11:20:10.3025513Z 	error: exit status 1
make generate	2025-01-24T11:20:10.3037631Z ##[error]Process completed with exit code 2.

Why: The go mod tidy command needs to be run to update the go.mod file with the necessary dependencies and remove any unused ones.

Suggested fix: Run go mod tidy to update the go.mod file and ensure all dependencies are correctly listed and any unused dependencies are removed.