Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy Mercury plugin and associated code #16014

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Conversation

samsondav
Copy link
Collaborator

@samsondav samsondav commented Jan 21, 2025

To be merged after plugin has been replaced by LLO.

Blocked on:

  1. Keystone (need to migrate DF2.0 to LLO and remove legacy scripts, etc)
  2. Data Streams (need to fully sunset all legacy feeds)

Also to be updated after this is merged:

  • chainlink-common (remove old legacy mercury loops plugin and related stuff)
  • chainlink-data-streams (remove mercury directory)

@samsondav samsondav force-pushed the MERC-6785 branch 4 times, most recently from 70f1dbe to dd54f46 Compare January 21, 2025 18:28
@samsondav samsondav force-pushed the MERC-6785 branch 2 times, most recently from 32cf4d5 to 84afb33 Compare January 23, 2025 16:46
@smartcontractkit smartcontractkit deleted a comment from github-actions bot Jan 23, 2025
@smartcontractkit smartcontractkit deleted a comment from github-actions bot Jan 23, 2025
Copy link
Contributor

github-actions bot commented Jan 23, 2025

AER Report: CI Core

aer_workflow , commit , Clean Go Tidy & Generate , Detect Changes , Scheduled Run Frequency , Core Tests (go_core_tests) , test-scripts , GolangCI Lint (.) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , lint , SonarQube Scan

1. Missing required module:

[job id: go_core_tests_integration]

Source of Error:
##[error]core/services/relay/evm/llo_provider.go:12:2: no required module provides package github.com/smartcontractkit/chainlink/v2/core/chains/evm/logpoller; to add it:
	go get github.com/smartcontractkit/chainlink/v2/core/chains/evm/logpoller
**Why**: The error indicates that the package `github.com/smartcontractkit/chainlink/v2/core/chains/evm/logpoller` is not available in the module dependencies.

Suggested fix: Ensure that the logpoller package is correctly listed in the go.mod file and run go mod tidy to update the dependencies.

[job id: test-scripts]

Source of Error:
##[error]../services/relay/evm/llo_provider.go:12:2: no required module provides package github.com/smartcontractkit/chainlink/v2/core/chains/evm/logpoller; to add it:
	go get github.com/smartcontractkit/chainlink/v2/core/chains/evm/logpoller
**Why**: The error indicates that the package `github.com/smartcontractkit/chainlink/v2/core/chains/evm/logpoller` is not available in the module dependencies.

Suggested fix: Ensure that the logpoller package is correctly listed in the go.mod file and run go mod tidy to update the dependencies.

[job id: go_core_ccip_deployment_tests]

Source of Error:
##[error]../core/services/relay/evm/llo_provider.go:12:2: no required module provides package github.com/smartcontractkit/chainlink/v2/core/chains/evm/logpoller; to add it:
	go get github.com/smartcontractkit/chainlink/v2/core/chains/evm/logpoller
**Why**: The error indicates that the package `github.com/smartcontractkit/chainlink/v2/core/chains/evm/logpoller` is not available in the module dependencies.

Suggested fix: Ensure that the logpoller package is correctly listed in the go.mod file and run go mod tidy to update the dependencies.

[job id: go_core_fuzz]

Source of Error:
##[error]core/services/relay/evm/llo_provider.go:12:2: no required module provides package github.com/smartcontractkit/chainlink/v2/core/chains/evm/logpoller; to add it:
	go get github.com/smartcontractkit/chainlink/v2/core/chains/evm/logpoller
**Why**: The error indicates that the package `github.com/smartcontractkit/chainlink/v2/core/chains/evm/logpoller` is not available in the module dependencies.

Suggested fix: Ensure that the logpoller package is correctly listed in the go.mod file and run go mod tidy to update the dependencies.

[job id: go_core_tests]

Source of Error:
##[error]core/services/relay/evm/llo_provider.go:12:2: no required module provides package github.com/smartcontractkit/chainlink/v2/core/chains/evm/logpoller; to add it:
	go get github.com/smartcontractkit/chainlink/v2/core/chains/evm/logpoller
**Why**: The error indicates that the package `github.com/smartcontractkit/chainlink/v2/core/chains/evm/logpoller` is not available in the module dependencies.

Suggested fix: Ensure that the logpoller package is correctly listed in the go.mod file and run go mod tidy to update the dependencies.

2. Undefined fields or methods:

[job id: GolangCI Lint (.))]

Source of Error:
##[error]core/internal/cltest/cltest.go:264:38: app.KeyStore undefined (type *TestApplication has no field or method KeyStore) (typecheck)
	k, _ := MustInsertRandomKey(t, app.KeyStore.Eth(), chainID)
**Why**: The `TestApplication` struct does not have a `KeyStore` field or method.

Suggested fix: Verify the TestApplication struct definition and ensure it includes the KeyStore field or method.

Source of Error:
##[error]core/internal/cltest/cltest.go:267:34: app.KeyStore undefined (type *TestApplication has no field or method KeyStore) (typecheck)
	id, ks := chainID.ToInt(), app.KeyStore.Eth()
**Why**: The `TestApplication` struct does not have a `KeyStore` field or method.

Suggested fix: Verify the TestApplication struct definition and ensure it includes the KeyStore field or method.

Source of Error:
##[error]core/internal/cltest/cltest.go:286:27: app.GetKeyStore undefined (type *TestApplication has no field or method GetKeyStore) (typecheck)
	require.NoError(t, app.GetKeyStore().P2P().Add(ctx, v))
**Why**: The `TestApplication` struct does not have a `GetKeyStore` method.

Suggested fix: Verify the TestApplication struct definition and ensure it includes the GetKeyStore method.

Source of Error:
##[error]core/internal/cltest/cltest.go:288:27: app.GetKeyStore undefined (type *TestApplication has no field or method GetKeyStore) (typecheck)
	require.NoError(t, app.GetKeyStore().CSA().Add(ctx, v))
**Why**: The `TestApplication` struct does not have a `GetKeyStore` method.

Suggested fix: Verify the TestApplication struct definition and ensure it includes the GetKeyStore method.

Source of Error:
##[error]core/internal/cltest/cltest.go:290:27: app.GetKeyStore undefined (type *TestApplication has no field or method GetKeyStore) (typecheck)
	require.NoError(t, app.GetKeyStore().OCR2().Add(ctx, v))
**Why**: The `TestApplication` struct does not have a `GetKeyStore` method.

Suggested fix: Verify the TestApplication struct definition and ensure it includes the GetKeyStore method.

Source of Error:
##[error]core/internal/cltest/cltest.go:652:12: ta.GetDB undefined (type *TestApplication has no field or method GetDB) (typecheck)
	err := ta.GetDB().GetContext(ctx, &id, `INSERT INTO sessions (id, email, last_used, created_at) VALUES ($1, $2, $3, NOW()) RETURNING id`, session.ID, email, session.LastUsed)
**Why**: The `TestApplication` struct does not have a `GetDB` method.

Suggested fix: Verify the TestApplication struct definition and ensure it includes the GetDB method.

Source of Error:
##[error]core/internal/cltest/cltest.go:659:27: ta.KeyStore undefined (type *TestApplication has no field or method KeyStore) (typecheck)
	require.NoError(ta.t, ta.KeyStore.Unlock(ctx, Password))
**Why**: The `TestApplication` struct does not have a `KeyStore` field or method.

Suggested fix: Verify the TestApplication struct definition and ensure it includes the KeyStore field or method.

Source of Error:
##[error]core/internal/cltest/cltest.go:660:15: ta.KeyStore undefined (type *TestApplication has no field or method KeyStore) (typecheck)
	_, err := ta.KeyStore.Eth().Import(ctx, []byte(content), Password, &FixtureChainID)
**Why**: The `TestApplication` struct does not have a `KeyStore` field or method.

Suggested fix: Verify the TestApplication struct definition and ensure it includes the KeyStore field or method.

Source of Error:
##[error]core/internal/cltest/cltest.go:688:11: ta.BasicAdminUsersORM undefined (type *TestApplication has no field or method BasicAdminUsersORM) (typecheck)
	err = ta.BasicAdminUsersORM().CreateUser(ctx, &u)
**Why**: The `TestApplication` struct does not have a `BasicAdminUsersORM` method.

Suggested fix: Verify the TestApplication struct definition and ensure it includes the BasicAdminUsersORM method.

Source of Error:
##[error]core/internal/cltest/cltest.go:710:38: ta.GetConfig undefined (type *TestApplication has no field or method GetConfig) (typecheck)
	Config: ta.GetConfig(),
**Why**: The `TestApplication` struct does not have a `GetConfig` method.

Suggested fix: Verify the TestApplication struct definition and ensure it includes the GetConfig method.

Source of Error:
##[error]core/internal/cltest/cltest.go:729:38: ta.GetConfig undefined (type *TestApplication has no field or method GetConfig) (typecheck)
	Config: ta.GetConfig(),
**Why**: The `TestApplication` struct does not have a `GetConfig` method.

Suggested fix: Verify the TestApplication struct definition and ensure it includes the GetConfig method.

Source of Error:
##[error]core/internal/cltest/cltest.go:1321:95: app.GetConfig undefined (type *TestApplication has no field or method GetConfig) (typecheck)
	ethClient.On("ConfiguredChainID", mock.Anything).Return(evmtest.MustGetDefaultChainID(t, app.GetConfig().EVMConfigs()), nil)
**Why**: The `TestApplication` struct does not have a `GetConfig` method.

Suggested fix: Verify the TestApplication struct definition and ensure it includes the GetConfig method.

Source of Error:
##[error]core/capabilities/integration_tests/framework/don.go:291:18: node.Stop undefined (type *capabilityNode has no field or method Stop) (typecheck)
	if err := node.Stop(); err != nil {
**Why**: The `capabilityNode` struct does not have a `Stop` method.

Suggested fix: Verify the capabilityNode struct definition and ensure it includes the Stop method.

Source of Error:
##[error]core/capabilities/integration_tests/framework/don.go:368:15: node.AddJobV2 undefined (type *capabilityNode has no field or method AddJobV2) (typecheck)
	err := node.AddJobV2(ctx, j)
**Why**: The `capabilityNode` struct does not have an `AddJobV2` method.

Suggested fix: Verify the capabilityNode struct definition and ensure it includes the AddJobV2 method.

Source of Error:
##[error]core/cmd/admin_commands.go:147:12: p.Role undefined (type *AdminUsersPresenter has no field or method Role) (typecheck)
	string(p.Role),
**Why**: The `AdminUsersPresenter` struct does not have a `Role` field or method.

Suggested fix: Verify the AdminUsersPresenter struct definition and ensure it includes the Role field or method.

Source of Error:
##[error]core/cmd/admin_commands.go:148:5: p.HasActiveApiToken undefined (type *AdminUsersPresenter has no field or method HasActiveApiToken) (typecheck)
	p.HasActiveApiToken,
**Why**: The `AdminUsersPresenter` struct does not have a `HasActiveApiToken` field or method.

Suggested fix: Verify the AdminUsersPresenter struct definition and ensure it includes the HasActiveApiToken field or method.

Source of Error:
##[error]core/cmd/admin_commands.go:149:5: p.CreatedAt undefined (type *AdminUsersPresenter has no field or method CreatedAt) (typecheck)
	p.CreatedAt.String(),
**Why**: The `AdminUsersPresenter` struct does not have a `CreatedAt` field or method.

Suggested fix: Verify the AdminUsersPresenter struct definition and ensure it includes the CreatedAt field or method.

Source of Error:
##[error]core/cmd/admin_commands.go:150:5: p.UpdatedAt undefined (type *AdminUsersPresenter has no field or method UpdatedAt) (typecheck)
	p.UpdatedAt.String(),
**Why**: The `AdminUsersPresenter` struct does not have a `UpdatedAt` field or method.

Suggested fix: Verify the AdminUsersPresenter struct definition and ensure it includes the UpdatedAt field or method.

Source of Error:
##[error]core/cmd/admin_commands.go:219:29: user.Email undefined (type AdminUsersPresenter has no field or method Email) (typecheck)
	if strings.EqualFold(user.Email, c.String("email")) {
**Why**: The `AdminUsersPresenter` struct does not have an `Email` field or method.

Suggested fix: Verify the AdminUsersPresenter struct definition and ensure it includes the Email field or method.

Source of Error:
##[error]core/cmd/admin_commands.go:220:75: user.Email undefined (type AdminUsersPresenter has no field or method Email) (typecheck)
	return s.errorOut(fmt.Errorf("user with email %s already exists", user.Email))
**Why**: The `AdminUsersPresenter` struct does not have an `Email` field or method.

Suggested fix: Verify the AdminUsersPresenter struct definition and ensure it includes the Email field or method.

Source of Error:
##[error]core/cmd/aptos_keys_commands.go:30:5: p.PubKey undefined (type *AptosKeyPresenter has no field or method PubKey) (typecheck)
	p.PubKey,
**Why**: The `AptosKeyPresenter` struct does not have a `PubKey` field or method.

Suggested fix: Verify the AptosKeyPresenter struct definition and ensure it includes the PubKey field or method.

Source of Error:
##[error]core/cmd/blocks_commands.go:100:20: p.EVMChainID undefined (type *LCAPresenter has no field or method EVMChainID) (typecheck)
	return []string{p.EVMChainID.String(), p.Hash, strconv.FormatInt(p.BlockNumber, 10)}
**Why**: The `LCAPresenter` struct does not have an `EVMChainID` field or method.

Suggested fix: Verify the LCAPresenter struct definition and ensure it includes the EVMChainID field or method.

Source of Error:
##[error]core/cmd/bridge_commands.go:50:37: p.Confirmations undefined (type *BridgePresenter has no field or method Confirmations) (typecheck)
	return strconv.FormatUint(uint64(p.Confirmations), 10)
**Why**: The `BridgePresenter` struct does not have a `Confirmations` field or method.

Suggested fix: Verify the BridgePresenter struct definition and ensure it includes the Confirmations field or method.

Source of Error:
##[error]core/cmd/bridge_commands.go:57:5: p.Name undefined (type *BridgePresenter has no field or method Name) (typecheck)
	p.Name,
**Why**: The `BridgePresenter` struct does not have a `Name` field or method.

Suggested fix: Verify the BridgePresenter struct definition and ensure it includes the Name field or method.

Source of Error:
##[error]core/cmd/bridge_commands.go:58:5: p.URL undefined (type *BridgePresenter has no field or method URL) (typecheck)
	p.URL,
**Why**: The `BridgePresenter` struct does not have a `URL` field or method.

Suggested fix: Verify the BridgePresenter struct definition and ensure it includes the URL field or method.

Source of Error:
##[error]core/cmd/bridge_commands.go:60:5: p.OutgoingToken
</cicore>
  
    
















<operatoruici>

## AER Report: [Operator UI CI](https://github.com/smartcontractkit/chainlink/actions/runs/13572023299) ran successfully :white_check_mark:

[aer_workflow](https://github.com/smartcontractkit/chainlink/actions/runs/13572057019/job/37939338345) , [commit](https://github.com/smartcontractkit/chainlink/commit/28db39a6d1a771019a1170c3e20384a01c1aa6d8)

</operatoruici>

@samsondav samsondav force-pushed the MERC-6785 branch 3 times, most recently from b84750e to d9253da Compare January 23, 2025 19:23
@samsondav samsondav force-pushed the MERC-6785 branch 3 times, most recently from 1a99108 to abad08c Compare February 11, 2025 15:36
Copy link
Contributor

Flakeguard Summary

Ran new or updated tests between develop and abad08c (MERC-6785).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

20 Results
Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestORM_CreateJob_KeyLocking 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/job false 20ms @smartcontractkit/foundations, @smartcontractkit/core
TestORM_CreateJob_KeyLocking/keys_locked 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/job false 0s @smartcontractkit/foundations, @smartcontractkit/core
TestORM_CreateJob_KeyLocking/keys_not_locked 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/job false 0s @smartcontractkit/foundations, @smartcontractkit/core
TestORM_CreateJob_OCR2_DuplicatedContractAddress 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/job false 10ms @smartcontractkit/foundations, @smartcontractkit/core
TestORM_CreateJob_OCR2_With_DualTransmission 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/job false 33.333333ms @smartcontractkit/foundations, @smartcontractkit/core
TestRunner 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/job false 150ms @smartcontractkit/foundations, @smartcontractkit/core
TestRunner/deleting_jobs 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/job false 0s @smartcontractkit/foundations, @smartcontractkit/core
TestRunner/handles_the_case_where_the_jsonparse_lookup_path_is_missing_from_the_http_response 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/job false 0s @smartcontractkit/foundations, @smartcontractkit/core
TestRunner/handles_the_case_where_the_jsonparse_lookup_path_is_missing_from_the_http_response_and_lax_is_enabled 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/job false 0s @smartcontractkit/foundations, @smartcontractkit/core
TestRunner/handles_the_case_where_the_parsed_value_is_literally_null 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/job false 0s @smartcontractkit/foundations, @smartcontractkit/core
TestRunner/minimal_bootstrap 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/job false 0s @smartcontractkit/foundations, @smartcontractkit/core
TestRunner/referencing_a_non-existent_bridge_should_error 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/job false 10ms @smartcontractkit/foundations, @smartcontractkit/core
TestRunner/test_enhanced_telemetry_service_creation 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/job false 10ms @smartcontractkit/foundations, @smartcontractkit/core
TestRunner/test_job_spec_error_is_created 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/job false 0s @smartcontractkit/foundations, @smartcontractkit/core
TestRunner/test_min_bootstrap 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/job false 0s @smartcontractkit/foundations, @smartcontractkit/core
TestRunner/test_min_non-bootstrap 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/job false 0s @smartcontractkit/foundations, @smartcontractkit/core
TestRunner/timeouts 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/job false 0s @smartcontractkit/foundations, @smartcontractkit/core
TestSpawner_CreateJobDeleteJob 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/job false 380ms @smartcontractkit/foundations, @smartcontractkit/core
TestSpawner_CreateJobDeleteJob/Unregisters_filters_on_'DeleteJob()' 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/job false 10ms @smartcontractkit/foundations, @smartcontractkit/core
Test_FindJob 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/job false 93.333333ms @smartcontractkit/foundations, @smartcontractkit/core

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

@samsondav samsondav force-pushed the MERC-6785 branch 6 times, most recently from c113ab5 to becd1db Compare February 11, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant