Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor secondary transmission #15358

Merged
merged 18 commits into from
Jan 13, 2025

Conversation

george-dorin
Copy link
Contributor

@george-dorin george-dorin commented Nov 21, 2024

Refactor dual transmitter and dual contract transmitter
Extra validation on dual transmission config

Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

Copy link
Contributor

github-actions bot commented Nov 21, 2024

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

Copy link
Contributor

Flaky Test Detector for github.com/smartcontractkit/chainlink project has failed ❌

Ran new or updated tests between develop and a916513 (update-secondary-transmission-method-signature).

View Flaky Detector Details | Compare Changes

Flaky Tests

Ran 69 unique tests. Below are the tests identified as flaky, with a pass ratio lower than the 99% threshold:

TestPackage                                                       TestName                             PassRatio  RunCount   Skipped
---------                                                         ---------                            ---------  ---------  ---------
github.com/smartcontractkit/chainlink/v2/core/services/relay/evm  Test_OCRContractTracker_IsLaterThan  50%        3          false

@george-dorin george-dorin marked this pull request as ready for review November 27, 2024 12:30
@george-dorin george-dorin requested review from a team as code owners November 27, 2024 12:30
@george-dorin george-dorin requested a review from ilija42 November 27, 2024 12:30
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
14.2% Duplication on New Code (required ≤ 10%)

See analysis details on SonarQube

@george-dorin george-dorin added this pull request to the merge queue Jan 13, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jan 13, 2025
* Refactor secondary transmission

* Add dual transmission ABI

* Update dual transmission ABI

* Update ABI
Add forwarder for secondary transmission

* Refactor dual transmitter
Add tests

* Add missing test file

* Add missing file

* Fix lint

* Fix lint
Fix test

* Pass txManagerOCR2 to ocr2FeedsDualTransmission

* Add dualTransmission meta validation

* Implement feedback

* Add ContractTransmitter helper function

* Add debug logging

* Add hint and refund validation

* rename file typo
Merged via the queue into develop with commit 1251ee3 Jan 13, 2025
185 of 188 checks passed
@george-dorin george-dorin deleted the update-secondary-transmission-method-signature branch January 13, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants