Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ERC165Checker in CapabilitiesRegistry #14231

Merged
merged 6 commits into from
Aug 27, 2024
Merged

Use ERC165Checker in CapabilitiesRegistry #14231

merged 6 commits into from
Aug 27, 2024

Conversation

DeividasK
Copy link
Collaborator

No description provided.

@DeividasK DeividasK requested a review from a team as a code owner August 26, 2024 13:59
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 26, 2024 •
edited
Loading

Static analysis results are available

Hey @app-token-issuer-infra-releng[bot], you can view Slither reports in the job summary here or download them as artifact here.

Please check them before merging and make sure you have addressed all issues.

@app-token-issuer-infra-releng app-token-issuer-infra-releng bot requested a review from a team as a code owner August 26, 2024 14:12
@app-token-issuer-infra-releng app-token-issuer-infra-releng bot requested review from EasterTheBunny and removed request for a team August 26, 2024 14:12
bolekk
bolekk reviewed Aug 26, 2024
View reviewed changes
contracts/src/v0.8/keystone/test/mocks/CapabilityConfigurationContract.sol
function supportsInterface(bytes4 interfaceId) public pure override returns (bool) {
return interfaceId == this.getCapabilityConfiguration.selector ^ this.beforeCapabilityConfigSet.selector;
function supportsInterface(bytes4 interfaceId) public pure returns (bool) {
return interfaceId == type(ICapabilityConfiguration).interfaceId || interfaceId == type(IERC165).interfaceId;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain this change please? Why don't we need to use selectors any more?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Combined selectors are produced by type(ICapabilityConfiguration).interfaceId. The main addition here is checking for type(IERC165).interfaceId, which was missing before.

@DeividasK
Merge remote-tracking branch 'origin/develop' into dk-use-ierc165-che…
f4b1309 
…cker

# Conflicts:
#	contracts/gas-snapshots/keystone.gas-snapshot
@DeividasK DeividasK force-pushed the dk-use-ierc165-checker branch from 7529371 to f4b1309 Compare August 26, 2024 14:44
bolekk
bolekk previously approved these changes Aug 26, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@DeividasK DeividasK added this pull request to the merge queue Aug 27, 2024
Merged via the queue into develop with commit 7a41ae7 Aug 27, 2024
151 of 154 checks passed
@DeividasK DeividasK deleted the dk-use-ierc165-checker branch August 27, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bolekk bolekk bolekk approved these changes

@aiagentdev-1990 aiagentdev-1990 aiagentdev-1990 approved these changes

@EasterTheBunny EasterTheBunny Awaiting requested review from EasterTheBunny EasterTheBunny was automatically assigned from smartcontractkit/foundations

@archseer archseer Awaiting requested review from archseer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DeividasK @bolekk @aiagentdev-1990