Expose Confirmed state to ChainWriter #14138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silaslenihan
force-pushed
the
expose-confirmed-state-to-chainwriter
branch
from
eb46d28 to
c665e24
Compare
silaslenihan
force-pushed
the
expose-confirmed-state-to-chainwriter
branch
2 times, most recently
from
2532665 to
a29cd59
Compare
silaslenihan
force-pushed
the
expose-confirmed-state-to-chainwriter
branch
from
a29cd59 to
5d486cf
Compare
amit-momin
reviewed
Aug 16, 2024
amit-momin
reviewed
Aug 16, 2024
Co-authored-by: amit-momin <[email protected]>
amit-momin
approved these changes
Aug 16, 2024
|
patrick-dowell
approved these changes
Aug 16, 2024
| @@ -654,8 +654,8 @@ func (b *Txm[CHAIN_ID, HEAD, ADDR, TX_HASH, BLOCK_HASH, R, SEQ, FEE]) GetTransac | |||
| } | |||
| switch tx.State { | |||
| case TxUnconfirmed, TxConfirmedMissingReceipt: | |||
| // Return unconfirmed for ConfirmedMissingReceipt since a receipt is required to determine if it is finalized | |||
| return commontypes.Unconfirmed, nil | |||
| // Return pending for ConfirmedMissingReceipt since a receipt is required to consider it as unconfirmed | |||
There was a problem hiding this comment.
nit: a receipt is required to consider it as confirmed
There was a problem hiding this comment.
Ohh, I think Unconfirmed means different things inside TXM, and in ChainWriter.
prashantkumar1982
approved these changes
Aug 16, 2024
This was referenced Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires Dependencies
smartcontractkit/chainlink-common#709
Resolves Dependencies
https://github.com/smartcontractkit/chainlink-evm-testing/pull/118