Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract the tx hash and log index from long upkeep IDs #13359

Closed
wants to merge 1 commit into from

Conversation

ferglor
Copy link
Collaborator

@ferglor ferglor commented May 29, 2024

Testing with short ID and txHash and log index:

./chaincli keeper debug 45922550481167474801016462395345942974472459369486901665448449256127185529335 0x9d3fa0425351ba3a6be7ac210e7d54df80739ef22477554a9091ee83a2b08b97 3
time=2024-05-29T17:27:41.248+01:00 level=INFO msg="Using config file .env"
time=2024-05-29T17:27:41.569+01:00 level=INFO msg="WARNING: no PRIVATE_KEY set: cannot use commands that deploy contracts or send transactions"
time=2024-05-29T17:27:41.840+01:00 level=INFO msg="☑️  upkeep identified as log trigger"
time=2024-05-29T17:27:41.961+01:00 level=INFO msg="☑️  LogTrigger{blockNum: 216280027, blockHash: 0x4d2ee4317c2c5502af030f30554a268b7df8d59d6a75ebae5cf40f1fbbd6b209, txHash: 0x9d3fa0425351ba3a6be7ac210e7d54df80739ef22477554a9091ee83a2b08b97, logIndex: 3}"
time=2024-05-29T17:27:41.961+01:00 level=INFO msg="☑️  workID computed: d8094814f1f37b6a8a2027fb2ea91122c7494b838aa7577b1a17b51f9a71fa40"
time=2024-05-29T17:27:42.017+01:00 level=INFO msg="❌ this upkeep is not eligible: upkeep was already performed"
time=2024-05-29T17:27:42.017+01:00 level=INFO msg="🔗 trigger transaction: https://arbiscan.io/tx/0x9d3fa0425351ba3a6be7ac210e7d54df80739ef22477554a9091ee83a2b08b97"

Testing with long ID only:

./chaincli keeper debug 45922550481167474801016462395345942974472459369486901665448449256127185529335100000000001711255346602003686424938128157527372926859822236223712615759645297259902759911000000000013
time=2024-05-29T17:28:29.419+01:00 level=INFO msg="Using config file .env"
time=2024-05-29T17:28:29.610+01:00 level=INFO msg="WARNING: no PRIVATE_KEY set: cannot use commands that deploy contracts or send transactions"
time=2024-05-29T17:28:29.807+01:00 level=INFO msg="☑️  long upkeep ID received"
time=2024-05-29T17:28:29.807+01:00 level=INFO msg="☑️  extracted upkeep ID: 45922550481167474801016462395345942974472459369486901665448449256127185529335"
time=2024-05-29T17:28:29.807+01:00 level=INFO msg="☑️  extracted log tx hash: 0x9d3fa0425351ba3a6be7ac210e7d54df80739ef22477554a9091ee83a2b08b97"
time=2024-05-29T17:28:29.807+01:00 level=INFO msg="☑️  extracted log index: 3"
time=2024-05-29T17:28:29.868+01:00 level=INFO msg="☑️  upkeep identified as log trigger"
time=2024-05-29T17:28:29.989+01:00 level=INFO msg="☑️  LogTrigger{blockNum: 216280027, blockHash: 0x4d2ee4317c2c5502af030f30554a268b7df8d59d6a75ebae5cf40f1fbbd6b209, txHash: 0x9d3fa0425351ba3a6be7ac210e7d54df80739ef22477554a9091ee83a2b08b97, logIndex: 3}"
time=2024-05-29T17:28:29.989+01:00 level=INFO msg="☑️  workID computed: d8094814f1f37b6a8a2027fb2ea91122c7494b838aa7577b1a17b51f9a71fa40"
time=2024-05-29T17:28:30.045+01:00 level=INFO msg="❌ this upkeep is not eligible: upkeep was already performed"
time=2024-05-29T17:28:30.045+01:00 level=INFO msg="🔗 trigger transaction: https://arbiscan.io/tx/0x9d3fa0425351ba3a6be7ac210e7d54df80739ef22477554a9091ee83a2b08b97"

Testing with long ID and txHash and a different log index:

./chaincli keeper debug 45922550481167474801016462395345942974472459369486901665448449256127185529335100000000001711255346602003686424938128157527372926859822236223712615759645297259902759911000000000013  0x9d3fa0425351ba3a6be7ac210e7d54df80739ef22477554a9091ee83a2b08b97 4
time=2024-05-29T17:29:06.527+01:00 level=INFO msg="Using config file .env"
time=2024-05-29T17:29:06.753+01:00 level=INFO msg="WARNING: no PRIVATE_KEY set: cannot use commands that deploy contracts or send transactions"
time=2024-05-29T17:29:06.953+01:00 level=INFO msg="☑️  long upkeep ID received"
time=2024-05-29T17:29:06.953+01:00 level=INFO msg="☑️  overriding log tx hash parameter 0x9d3fa0425351ba3a6be7ac210e7d54df80739ef22477554a9091ee83a2b08b97 with extracted log tx hash 0x9d3fa0425351ba3a6be7ac210e7d54df80739ef22477554a9091ee83a2b08b97"
time=2024-05-29T17:29:06.953+01:00 level=INFO msg="☑️  overriding log index parameter 4 with extracted log index 3"
time=2024-05-29T17:29:06.953+01:00 level=INFO msg="☑️  extracted upkeep ID: 45922550481167474801016462395345942974472459369486901665448449256127185529335"
time=2024-05-29T17:29:06.953+01:00 level=INFO msg="☑️  extracted log tx hash: 0x9d3fa0425351ba3a6be7ac210e7d54df80739ef22477554a9091ee83a2b08b97"
time=2024-05-29T17:29:06.953+01:00 level=INFO msg="☑️  extracted log index: 3"
time=2024-05-29T17:29:07.048+01:00 level=INFO msg="☑️  upkeep identified as log trigger"
time=2024-05-29T17:29:07.165+01:00 level=INFO msg="☑️  LogTrigger{blockNum: 216280027, blockHash: 0x4d2ee4317c2c5502af030f30554a268b7df8d59d6a75ebae5cf40f1fbbd6b209, txHash: 0x9d3fa0425351ba3a6be7ac210e7d54df80739ef22477554a9091ee83a2b08b97, logIndex: 3}"
time=2024-05-29T17:29:07.165+01:00 level=INFO msg="☑️  workID computed: d8094814f1f37b6a8a2027fb2ea91122c7494b838aa7577b1a17b51f9a71fa40"
time=2024-05-29T17:29:07.223+01:00 level=INFO msg="❌ this upkeep is not eligible: upkeep was already performed"
time=2024-05-29T17:29:07.223+01:00 level=INFO msg="🔗 trigger transaction: https://arbiscan.io/tx/0x9d3fa0425351ba3a6be7ac210e7d54df80739ef22477554a9091ee83a2b08b97"

@ferglor ferglor requested a review from a team as a code owner May 29, 2024 16:37
Copy link
Contributor

github-actions bot commented May 29, 2024

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Contributor

@shileiwill shileiwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jul 30, 2024
@github-actions github-actions bot closed this Aug 7, 2024
@ferglor ferglor reopened this Aug 27, 2024
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@github-actions github-actions bot removed the Stale label Aug 28, 2024
Copy link
Contributor

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Oct 27, 2024
@github-actions github-actions bot closed this Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants