Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Add Scroll chainType and L1GasOracle #11790

Merged
merged 6 commits into from
Jan 18, 2024
Merged

[Fix] Add Scroll chainType and L1GasOracle #11790

merged 6 commits into from
Jan 18, 2024

Conversation

stackman27
Copy link
Contributor

No description provided.

@stackman27 stackman27 requested a review from amit-momin January 16, 2024 19:10
@github-actions GitHub Actions
Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

amit-momin
amit-momin previously approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@amit-momin amit-momin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but think we should wait for a ship pod approval before merging

@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@stackman27 stackman27 requested a review from amit-momin January 16, 2024 23:10
@prashantkumar1982 prashantkumar1982 added this pull request to the merge queue Jan 18, 2024
Merged via the queue into develop with commit 39847bb Jan 18, 2024
82 checks passed
@prashantkumar1982 prashantkumar1982 deleted the sis/scroll-gas branch January 18, 2024 01:57
This was referenced Feb 22, 2024
Closed
Closed
@snehaagni snehaagni mentioned this pull request Mar 7, 2024
Closed
This was referenced Mar 21, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prashantkumar1982 prashantkumar1982 prashantkumar1982 approved these changes

@amit-momin amit-momin amit-momin approved these changes

@samsondav samsondav Awaiting requested review from samsondav

@mohamed-mehany mohamed-mehany Awaiting requested review from mohamed-mehany

@connorwstein connorwstein Awaiting requested review from connorwstein

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stackman27 @prashantkumar1982 @amit-momin