Skip to content

Commit

Permalink
Reverts unsupported approach
Browse files Browse the repository at this point in the history
  • Loading branch information
vyzaldysanchez committed Nov 7, 2024
1 parent 362ead7 commit 24e58bb
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 9 deletions.
9 changes: 1 addition & 8 deletions core/platform/monitoring.go
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
package platform

import (
"iter"
"slices"
)

// Observability keys
const (
KeyCapabilityID = "capabilityID"
Expand All @@ -17,6 +12,4 @@ const (
KeyStepRef = "stepRef"
)

func KeysSorted() iter.Seq[string] {
return slices.Values([]string{KeyStepRef, KeyStepID, KeyTriggerID, KeyCapabilityID, KeyWorkflowExecutionID, KeyWorkflowID})
}
var OrderedLabelKeys = []string{KeyStepRef, KeyStepID, KeyTriggerID, KeyCapabilityID, KeyWorkflowExecutionID, KeyWorkflowID}
2 changes: 1 addition & 1 deletion core/services/workflows/engine.go
Original file line number Diff line number Diff line change
Expand Up @@ -1269,7 +1269,7 @@ func (e *workflowError) Error() string {
}

// prefix the error with the labels
for label := range platform.KeysSorted() {
for _, label := range platform.OrderedLabelKeys {
// This will silently ignore any labels that are not present in the map
// are we ok with this?
if value, ok := e.labels[label]; ok {
Expand Down

0 comments on commit 24e58bb

Please sign in to comment.