Config validation for kms

smartcontractkit · Sep 18, 2024 · 188e993 · 188e993
1 parent b5f1c48
commit 188e993
Showing 1 changed file with 13 additions and 10 deletions.
diff --git a/integration-tests/deployment/evm_kmsclient.go b/integration-tests/deployment/evm_kmsclient.go
@@ -56,17 +56,20 @@ type KMS struct {
 	AwsProfileName       string
 }
 
-func NewKMSClient(config KMS) KMSClient {
-	if config.KmsDeployerKeyId != "" && config.KmsDeployerKeyRegion != "" {
-		var awsSessionFn AwsSessionFn
-		if config.AwsProfileName != "" {
-			awsSessionFn = awsSessionFromProfileFn
-		} else {
-			awsSessionFn = awsSessionFromEnvVarsFn
-		}
-		return kms.New(awsSessionFn(config))
+func NewKMSClient(config KMS) (KMSClient, error) {
+	if config.KmsDeployerKeyId == "" {
+		return nil, fmt.Errorf("KMS key ID is required")
+	}
+	if config.KmsDeployerKeyRegion == "" {
+		return nil, fmt.Errorf("KMS key region is required")
+	}
+	var awsSessionFn AwsSessionFn
+	if config.AwsProfileName != "" {
+		awsSessionFn = awsSessionFromProfileFn
+	} else {
+		awsSessionFn = awsSessionFromEnvVarsFn
 	}
-	return nil
+	return kms.New(awsSessionFn(config)), nil
 }
 
 type EVMKMSClient struct {