Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Basic GetLatestValue for Solana #612

Merged
merged 14 commits into from
Mar 14, 2024
Merged

Implement Basic GetLatestValue for Solana #612

merged 14 commits into from
Mar 14, 2024

Conversation

EasterTheBunny
Copy link
Contributor

@EasterTheBunny EasterTheBunny commented Mar 4, 2024 •
edited
Loading

This commit fills in the functionality for GetLatestValue such that one or more accounts with an associated Anchor IDl can be read and mapped to native Go structs. Methods and prodecures can be defined in a config where an IDL and codec modifiers can be provided.

@EasterTheBunny EasterTheBunny force-pushed the BCF-3014-implement-getlatestvalue branch from 09e5564 to 9917390 Compare March 4, 2024 18:05
@EasterTheBunny EasterTheBunny force-pushed the BCF-3014-implement-getlatestvalue branch from 9917390 to 94a02b7 Compare March 4, 2024 18:19
@EasterTheBunny EasterTheBunny force-pushed the BCF-3014-implement-getlatestvalue branch from 94a02b7 to 427dc6c Compare March 4, 2024 18:57
@EasterTheBunny EasterTheBunny force-pushed the BCF-3014-implement-getlatestvalue branch from 427dc6c to 32745c0 Compare March 4, 2024 19:48
@EasterTheBunny EasterTheBunny force-pushed the BCF-3014-implement-getlatestvalue branch from 32745c0 to 6449ef4 Compare March 4, 2024 19:59
@EasterTheBunny EasterTheBunny force-pushed the BCF-3014-implement-getlatestvalue branch from 6449ef4 to c7f4a90 Compare March 4, 2024 22:02
@EasterTheBunny EasterTheBunny force-pushed the BCF-3014-implement-getlatestvalue branch from c7f4a90 to e5a3959 Compare March 5, 2024 14:54
@EasterTheBunny EasterTheBunny requested a review from nolag March 14, 2024 20:35
reductionista
reductionista previously approved these changes Mar 14, 2024
View reviewed changes
@reductionista
Copy link
Contributor

LGTM!

aalu1418
aalu1418 requested changes Mar 14, 2024
View reviewed changes
Copy link
Collaborator

@aalu1418 aalu1418 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we move the chainreader components into pkg/solana/chainreader?

i'd like to try and organize things in the repo a little better :)

aalu1418
aalu1418 previously approved these changes Mar 14, 2024
View reviewed changes
Copy link
Collaborator

@aalu1418 aalu1418 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

concerns addressed!
I will leave the logic review to @reductionista and @nolag - who approved previously

@aalu1418 aalu1418 enabled auto-merge (squash) March 14, 2024 22:10
@aalu1418 aalu1418 merged commit 3c2d018 into develop Mar 14, 2024
24 checks passed
@aalu1418 aalu1418 deleted the BCF-3014-implement-getlatestvalue branch March 14, 2024 22:21
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aalu1418 aalu1418 aalu1418 approved these changes

@reductionista reductionista reductionista left review comments

@ilija42 ilija42 Awaiting requested review from ilija42

@nolag nolag Awaiting requested review from nolag

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EasterTheBunny @reductionista @nolag @aalu1418