Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ExtraArgs ComputeLimit to CCIP Execute transform func #1106

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Added ExtraArgs ComputeLimit to CCIP Execute transform func #1106

wants to merge 4 commits into from
+171 −36

Conversation

silaslenihan
Copy link
Contributor

Description

Requires Dependencies

Resolves Dependencies

@silaslenihan silaslenihan requested review from a team as code owners February 25, 2025 17:50
silaslenihan
silaslenihan commented Feb 25, 2025
View reviewed changes
pkg/solana/chainwriter/transform_registry.go
ReportContext [2][32]byte
Report []byte
Info ccipocr3.ExecuteReportInfo
AbstractReport ccip_offramp.ExecutionReportSingleChain
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the AbstractReport field here since that field isn't in the off-chain or on-chain report objects, not sure how it got in here in the first place

@silaslenihan silaslenihan force-pushed the include-extraargs-computelimit branch from 4995a6f to 1827cf6 Compare February 25, 2025 18:25
@silaslenihan silaslenihan force-pushed the include-extraargs-computelimit branch from cdbf7e7 to 7bab39b Compare February 25, 2025 20:17
@silaslenihan silaslenihan force-pushed the include-extraargs-computelimit branch from 7bab39b to 40212eb Compare February 25, 2025 20:26
@silaslenihan silaslenihan force-pushed the include-extraargs-computelimit branch from fafc794 to 74da593 Compare February 25, 2025 20:38
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
74.1% Coverage on New Code (required ≥ 75%)

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amit-momin amit-momin amit-momin left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silaslenihan @amit-momin