Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix collision on multiread #1100

Merged
merged 2 commits into from
Feb 24, 2025
Merged

Fix collision on multiread #1100

merged 2 commits into from
Feb 24, 2025

Conversation

archseer
Copy link
Collaborator

Without this fix using the same multiread in different methods would cause a collision.

e.g. I had this definition with the Rename modifier, and it caused the same rename in other unrelated methods that were using ReferenceAddresses.

								{
									ChainSpecificName: "ReferenceAddresses",
									ReadType:          config.Account,
									PDADefinition: solanacodec.PDATypeDef{
										Prefix: []byte("reference_addresses"),
									},
									OutputModifications: codec.ModifiersConfig{
										&codec.RenameModifierConfig{Fields: map[string]string{"Router": "NonceManager"}},
									},
								},

@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 75%)

See analysis details on SonarQube

@archseer archseer merged commit 0bbe002 into develop Feb 24, 2025
35 of 36 checks passed
@archseer archseer deleted the fix-multiread branch February 24, 2025 16:00
silaslenihan pushed a commit that referenced this pull request Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants