ChainWriter: Specify Ignorable Errors for Optional Lookups #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silaslenihan
temporarily deployed
to
integration
GitHub Actions
Inactive
silaslenihan
had a problem deploying
to
integration
GitHub Actions
Error
silaslenihan
temporarily deployed
to
integration
GitHub Actions
Inactive
silaslenihan
had a problem deploying
to
integration
GitHub Actions
Error
silaslenihan
force-pushed
the
specify-ignorable-errors
branch
from
c09fef6 to
455c94e
Compare
silaslenihan
had a problem deploying
to
integration
GitHub Actions
Error
silaslenihan
temporarily deployed
to
integration
GitHub Actions
Inactive
silaslenihan
temporarily deployed
to
integration
GitHub Actions
Inactive
silaslenihan
had a problem deploying
to
integration
GitHub Actions
Error
silaslenihan
force-pushed
the
specify-ignorable-errors
branch
from
455c94e to
8a5e328
Compare
silaslenihan
temporarily deployed
to
integration
GitHub Actions
Inactive
silaslenihan
had a problem deploying
to
integration
GitHub Actions
Error
silaslenihan
temporarily deployed
to
integration
GitHub Actions
Inactive
silaslenihan
had a problem deploying
to
integration
GitHub Actions
Error
silaslenihan
force-pushed
the
specify-ignorable-errors
branch
from
8a5e328 to
60efbd1
Compare
silaslenihan
temporarily deployed
to
integration
GitHub Actions
Inactive
silaslenihan
temporarily deployed
to
integration
GitHub Actions
Inactive
silaslenihan
temporarily deployed
to
integration
GitHub Actions
Inactive
silaslenihan
temporarily deployed
to
integration
GitHub Actions
Inactive
silaslenihan
had a problem deploying
to
integration
GitHub Actions
Error
amit-momin
reviewed
Feb 19, 2025
silaslenihan
force-pushed
the
specify-ignorable-errors
branch
from
60efbd1 to
435dbe3
Compare
silaslenihan
temporarily deployed
to
integration
GitHub Actions
Inactive
silaslenihan
temporarily deployed
to
integration
GitHub Actions
Inactive
silaslenihan
temporarily deployed
to
integration
GitHub Actions
Inactive
silaslenihan
temporarily deployed
to
integration
GitHub Actions
Inactive
amit-momin
approved these changes
Feb 19, 2025
silaslenihan
temporarily deployed
to
integration
GitHub Actions
Inactive
silaslenihan
changed the title
prashantkumar1982
approved these changes
Feb 20, 2025
silaslenihan
temporarily deployed
to
integration
GitHub Actions
Inactive
silaslenihan
temporarily deployed
to
integration
GitHub Actions
Inactive
silaslenihan
temporarily deployed
to
integration
GitHub Actions
Inactive
silaslenihan
temporarily deployed
to
integration
GitHub Actions
Inactive
silaslenihan
temporarily deployed
to
integration
GitHub Actions
Inactive
jadepark-dev
temporarily deployed
to
integration
GitHub Actions
Inactive
jadepark-dev
temporarily deployed
to
integration
GitHub Actions
Inactive
jadepark-dev
temporarily deployed
to
integration
GitHub Actions
Inactive
jadepark-dev
temporarily deployed
to
integration
GitHub Actions
Inactive
jadepark-dev
approved these changes
Feb 20, 2025
jadepark-dev
temporarily deployed
to
integration
GitHub Actions
Inactive
|
archseer
added a commit
that referenced
this pull request
Feb 20, 2025
Squashed commit of the following: commit 382b20d Merge: 77708c9 3333854 Author: ilija42 <[email protected]> Date: Thu Feb 20 13:48:09 2025 +0100 Merge branch 'develop' into NONEVM-1064/querykey-integration-tests commit 77708c9 Author: ilija <[email protected]> Date: Thu Feb 20 13:47:51 2025 +0100 Fix disable tests CR comments commit 0be9fb0 Author: ilija <[email protected]> Date: Thu Feb 20 13:45:54 2025 +0100 lint and gen CR test contract commit f4f91a4 Author: ilija <[email protected]> Date: Thu Feb 20 13:34:19 2025 +0100 Format CR test contract commit 30904a7 Author: ilija <[email protected]> Date: Thu Feb 20 13:28:30 2025 +0100 Bump common commit 3b6eaa0 Author: ilija <[email protected]> Date: Thu Feb 20 13:15:29 2025 +0100 Enable ContractReaderQueryKeyCanFilterWithValueComparator test commit c52a9b4 Author: ilija <[email protected]> Date: Thu Feb 20 13:11:16 2025 +0100 Revert big int encoding changes commit 0c2117f Author: ilija <[email protected]> Date: Thu Feb 20 11:32:19 2025 +0100 Fix encode comparator item type commit 3333854 Author: Silas Lenihan <[email protected]> Date: Thu Feb 20 04:09:55 2025 -0500 Specify Ignorable Errors for Optional Lookups (#1091) Co-authored-by: Jonghyeon Park <[email protected]> commit e8b2d8a Author: Blaž Hrastnik <[email protected]> Date: Thu Feb 20 17:51:29 2025 +0900 chainreader: fix regression: RPC requires an array of items, not nil (#1092) commit 1386b72 Author: Awbrey Hughlett <[email protected]> Date: Wed Feb 19 15:37:03 2025 -0600 clean up existing tests commit 37222a9 Author: Awbrey Hughlett <[email protected]> Date: Wed Feb 19 12:27:59 2025 -0600 add dep to latest common with modifier commit d57bd32 Author: Awbrey Hughlett <[email protected]> Date: Tue Feb 18 11:47:19 2025 -0600 update chain writer to emit events for interface tests commit 750af14 Author: Awbrey Hughlett <[email protected]> Date: Mon Feb 17 15:17:29 2025 -0600 first test functional commit e6b4993 Author: Awbrey Hughlett <[email protected]> Date: Wed Feb 19 13:41:07 2025 -0600 exclusively use big endian for big ints commit 00e3388 Author: Awbrey Hughlett <[email protected]> Date: Wed Feb 19 16:03:47 2025 -0600 further bug fixes to enable event querying commit 8c0e7b5 Author: Awbrey Hughlett <[email protected]> Date: Tue Feb 18 19:13:14 2025 -0600 change event sig type, assigning subkey values to idx, remove unused code commit 5b3f19f Author: Domino Valdano <[email protected]> Date: Tue Feb 18 12:14:49 2025 -0800 Add missing call to addReadNameForContract() commit a824851 Author: Awbrey Hughlett <[email protected]> Date: Tue Feb 18 12:03:19 2025 -0600 use string value for address and update writer to use chain specific name
archseer
added a commit
that referenced
this pull request
Feb 22, 2025
Squashed commit of the following: commit 382b20d Merge: 77708c9 3333854 Author: ilija42 <[email protected]> Date: Thu Feb 20 13:48:09 2025 +0100 Merge branch 'develop' into NONEVM-1064/querykey-integration-tests commit 77708c9 Author: ilija <[email protected]> Date: Thu Feb 20 13:47:51 2025 +0100 Fix disable tests CR comments commit 0be9fb0 Author: ilija <[email protected]> Date: Thu Feb 20 13:45:54 2025 +0100 lint and gen CR test contract commit f4f91a4 Author: ilija <[email protected]> Date: Thu Feb 20 13:34:19 2025 +0100 Format CR test contract commit 30904a7 Author: ilija <[email protected]> Date: Thu Feb 20 13:28:30 2025 +0100 Bump common commit 3b6eaa0 Author: ilija <[email protected]> Date: Thu Feb 20 13:15:29 2025 +0100 Enable ContractReaderQueryKeyCanFilterWithValueComparator test commit c52a9b4 Author: ilija <[email protected]> Date: Thu Feb 20 13:11:16 2025 +0100 Revert big int encoding changes commit 0c2117f Author: ilija <[email protected]> Date: Thu Feb 20 11:32:19 2025 +0100 Fix encode comparator item type commit 3333854 Author: Silas Lenihan <[email protected]> Date: Thu Feb 20 04:09:55 2025 -0500 Specify Ignorable Errors for Optional Lookups (#1091) Co-authored-by: Jonghyeon Park <[email protected]> commit e8b2d8a Author: Blaž Hrastnik <[email protected]> Date: Thu Feb 20 17:51:29 2025 +0900 chainreader: fix regression: RPC requires an array of items, not nil (#1092) commit 1386b72 Author: Awbrey Hughlett <[email protected]> Date: Wed Feb 19 15:37:03 2025 -0600 clean up existing tests commit 37222a9 Author: Awbrey Hughlett <[email protected]> Date: Wed Feb 19 12:27:59 2025 -0600 add dep to latest common with modifier commit d57bd32 Author: Awbrey Hughlett <[email protected]> Date: Tue Feb 18 11:47:19 2025 -0600 update chain writer to emit events for interface tests commit 750af14 Author: Awbrey Hughlett <[email protected]> Date: Mon Feb 17 15:17:29 2025 -0600 first test functional commit e6b4993 Author: Awbrey Hughlett <[email protected]> Date: Wed Feb 19 13:41:07 2025 -0600 exclusively use big endian for big ints commit 00e3388 Author: Awbrey Hughlett <[email protected]> Date: Wed Feb 19 16:03:47 2025 -0600 further bug fixes to enable event querying commit 8c0e7b5 Author: Awbrey Hughlett <[email protected]> Date: Tue Feb 18 19:13:14 2025 -0600 change event sig type, assigning subkey values to idx, remove unused code commit 5b3f19f Author: Domino Valdano <[email protected]> Date: Tue Feb 18 12:14:49 2025 -0800 Add missing call to addReadNameForContract() commit a824851 Author: Awbrey Hughlett <[email protected]> Date: Tue Feb 18 12:03:19 2025 -0600 use string value for address and update writer to use chain specific name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rather than ignoring any error on an optional lookup, only ignore anticipated ones such as an argument not being found or a lookup table being missing.
Requires Dependencies
Resolves Dependencies