Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve account reading err handling and fix get token prices for a non loop call #1079

Merged
merged 6 commits into from
Feb 17, 2025

Conversation

ilija42
Copy link
Contributor

@ilija42 ilija42 commented Feb 16, 2025

Description

Requires Dependencies

Resolves Dependencies

@ilija42 ilija42 changed the title Handle get token prices for map params Improve account reading err handling and fix get token prices for a non loop call Feb 17, 2025
@ilija42 ilija42 marked this pull request as ready for review February 17, 2025 00:06
@ilija42 ilija42 requested review from a team as code owners February 17, 2025 00:06
@ilija42 ilija42 changed the base branch from develop to change-cr-batch-err-handling February 17, 2025 00:07
@ilija42 ilija42 merged commit e409541 into change-cr-batch-err-handling Feb 17, 2025
11 of 12 checks passed
@ilija42 ilija42 deleted the fix-get-token-prices branch February 17, 2025 00:10
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 75%)

See analysis details on SonarQube

chris-de-leon-cll pushed a commit that referenced this pull request Feb 20, 2025
…n loop call #1079 (#1078)

* Change CR handling for Addresses not found

* lint

* Improve account reading err handling and fix get token prices for a non loop call (#1079)

* Handle get token prices for map params

* Fix getPDAsForGetTokenPrices handling for non Loop call

* Fix getPDAsForGetTokenPrices handling for non Loop call

* Tidy

* lint

* fix cr test

* Refactor fix, don't discard account data from accounts we were able to read

* Implement ErrOnMissingAccountData flag for CR calls

* cleanup

* fix merge issues

---------

Co-authored-by: Blaž Hrastnik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant