Change account reading err handling and fix get token prices for a non loop call #1079 #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on loop call (#1079) * Handle get token prices for map params * Fix getPDAsForGetTokenPrices handling for non Loop call * Fix getPDAsForGetTokenPrices handling for non Loop call * Tidy * lint
ilija42
changed the title
amit-momin
reviewed
Feb 17, 2025
ilija42
force-pushed
the
change-cr-batch-err-handling
branch
from
66fe85e to
e409541
Compare
amit-momin
approved these changes
Feb 19, 2025
chris-de-leon-cll
approved these changes
Feb 19, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PDAs are often not initialised immediately, on EVM this corresponded do method calls that returned empty data. Mimick this behaviour by not returning an error when an account address is not found.
Also fix get token prices for a non loop call