Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add json tags and enable serialization for ChainWriter config #1072

Merged
merged 7 commits into from
Feb 13, 2025
Merged

Add json tags and enable serialization for ChainWriter config #1072

merged 7 commits into from
Feb 13, 2025

Conversation

amit-momin
Copy link
Contributor

@amit-momin amit-momin commented Feb 12, 2025 •
edited
Loading

core ref: c684df5dc2eb46dc1201777c435b4f114c7ea362

Added json tags to ChainWriter Config and updated Lookup type to be a struct with mutually exclusive underlying lookup types rather than an interface to enable serialization

archseer
archseer previously approved these changes Feb 12, 2025
View reviewed changes
@silaslenihan silaslenihan changed the title Add json tags to ChainWriter config Add json tags and enable serialization for ChainWriter config Feb 12, 2025
@silaslenihan silaslenihan force-pushed the add-json-tags-chainwriter-config branch from 9c60a03 to d89966c Compare February 12, 2025 21:30
@silaslenihan silaslenihan marked this pull request as ready for review February 12, 2025 21:30
@silaslenihan silaslenihan requested review from a team as code owners February 12, 2025 21:30
This was referenced Feb 12, 2025
Closed
Merged
@silaslenihan silaslenihan force-pushed the add-json-tags-chainwriter-config branch from a82a277 to 7d39f9b Compare February 12, 2025 22:15
@amit-momin amit-momin force-pushed the add-json-tags-chainwriter-config branch from 48e2efc to ec3d6ba Compare February 13, 2025 03:09
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
1 New issue
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
90.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@archseer archseer enabled auto-merge (squash) February 13, 2025 03:52
@archseer archseer merged commit e727e73 into develop Feb 13, 2025
36 checks passed
@archseer archseer deleted the add-json-tags-chainwriter-config branch February 13, 2025 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archseer archseer archseer approved these changes

@silaslenihan silaslenihan silaslenihan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amit-momin @archseer @silaslenihan