Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added optional field for lookups & added IDL to InternalField #1058

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Added optional field for lookups & added IDL to InternalField #1058

merged 1 commit into from
Feb 10, 2025

Conversation

silaslenihan
Copy link
Contributor

@silaslenihan silaslenihan commented Feb 10, 2025 •
edited
Loading

core ref: 41da9bafca488a87b23a7847e014122c31a74d91

Description

This PR Contains two changes to the ChainWriter:

  1. Add optional flag to Lookups so that errors from not being able to resolve them are ignored. this will be necessary for CCIP since not all messages contain token transfers / extraArgs, so they'll need to be marked as optional in the CW config.
  2. Added IDL field to InternalField. This is necessary because the CCIP router and offramp were split up and we need to do PDA lookups on both of them for execute reports, so we need to be able to point to a secondary IDL (router) for certain lookups (TokenAdminRegistry)

Requires Dependencies

Resolves Dependencies

@silaslenihan silaslenihan force-pushed the cw-accounts-optional-field branch from e8655c0 to dc3be4f Compare February 10, 2025 16:30
@silaslenihan silaslenihan changed the title Added optional field for lookups Added optional field for lookups & added IDL to InternalField Feb 10, 2025
@silaslenihan silaslenihan marked this pull request as ready for review February 10, 2025 16:57
@silaslenihan silaslenihan requested review from a team as code owners February 10, 2025 16:57
amit-momin
amit-momin previously approved these changes Feb 10, 2025
View reviewed changes
@silaslenihan silaslenihan force-pushed the cw-accounts-optional-field branch from dc3be4f to 316ee1f Compare February 10, 2025 17:34
@silaslenihan silaslenihan force-pushed the cw-accounts-optional-field branch from 316ee1f to 70ce21e Compare February 10, 2025 17:42
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 75%)

See analysis details on SonarQube

@toblich toblich merged commit cc142c0 into develop Feb 10, 2025
35 of 36 checks passed
@toblich toblich deleted the cw-accounts-optional-field branch February 10, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toblich toblich toblich approved these changes

@amit-momin amit-momin amit-momin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@silaslenihan @toblich @amit-momin