Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Automatic ATA Creation in ChainWriter #1033

Merged
merged 15 commits into from
Feb 13, 2025
Merged

Enable Automatic ATA Creation in ChainWriter #1033

merged 15 commits into from
Feb 13, 2025

Conversation

silaslenihan
Copy link
Contributor

@silaslenihan silaslenihan commented Jan 29, 2025 •
edited
Loading

core ref: 8b048022c936ee2ca405707b4664081a44b9a26d

Description

Enables ATA Creation when necessary based on the ChainWriter config. The code is based on this design, but has been altered slightly.

Also, this PR refactors the ChainWriter to use the MultiClient rather than a single RPC client set at initialization.

Requires Dependencies

Resolves Dependencies

@silaslenihan silaslenihan changed the base branch from develop to ccip-config-example-updates January 29, 2025 22:25
@silaslenihan silaslenihan force-pushed the ccip-config-example-updates branch from 9155c31 to 4bd3449 Compare January 29, 2025 22:27
Base automatically changed from ccip-config-example-updates to develop January 30, 2025 07:53
@silaslenihan silaslenihan force-pushed the ata-creation branch 2 times, most recently from 66c9448 to 78dc10f Compare January 30, 2025 19:22
amit-momin
amit-momin previously approved these changes Feb 13, 2025
View reviewed changes
amit-momin
amit-momin previously approved these changes Feb 13, 2025
View reviewed changes
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
29.7% Coverage on New Code (required ≥ 75%)

See analysis details on SonarQube

@toblich toblich merged commit e15b133 into develop Feb 13, 2025
34 of 36 checks passed
@toblich toblich deleted the ata-creation branch February 13, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huangzhen1997 huangzhen1997 huangzhen1997 left review comments

@toblich toblich toblich approved these changes

@prashantkumar1982 prashantkumar1982 prashantkumar1982 approved these changes

@amit-momin amit-momin Awaiting requested review from amit-momin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@silaslenihan @toblich @huangzhen1997 @prashantkumar1982 @amit-momin