Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CAPPL-536] Workflow update not picked up by Syncer #1048

Merged
merged 3 commits into from
Feb 25, 2025
Merged

[CAPPL-536] Workflow update not picked up by Syncer #1048

merged 3 commits into from
Feb 25, 2025
+62 −5

Conversation

agparadiso
Copy link
Contributor

@agparadiso agparadiso commented Feb 24, 2025 •
edited
Loading

Description

this is a follow up of this pr
in the prev pr the ACK message was nil, making the client fail:

        msg := &capabilitiespb.TriggerResponseMessage{
		Message: &capabilitiespb.TriggerResponseMessage_Ack{
			Ack: &emptypb.Empty{},
		},
	}

CAPPL-536

Requires

Supports

@agparadiso agparadiso force-pushed the CAPPL-536_update_not_picked_up_by_syncer_fix branch from 370e596 to 17d5763 Compare February 24, 2025 10:57
@agparadiso agparadiso force-pushed the CAPPL-536_update_not_picked_up_by_syncer_fix branch from e22a4a0 to 17d5763 Compare February 24, 2025 16:42
@agparadiso agparadiso changed the title wip [CAPPL-536] synchronise RegisterTrigger client and server using a first ack/err message Feb 24, 2025
@agparadiso agparadiso changed the title [CAPPL-536] synchronise RegisterTrigger client and server using a first ack/err message [CAPPL-536] Workflow update not picked up by Syncer Feb 24, 2025
@agparadiso agparadiso marked this pull request as ready for review February 24, 2025 16:50
@agparadiso agparadiso requested a review from a team as a code owner February 24, 2025 16:50
@agparadiso agparadiso merged commit f0e1dd7 into main Feb 25, 2025
15 checks passed
@agparadiso agparadiso deleted the CAPPL-536_update_not_picked_up_by_syncer_fix branch February 25, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhuie19 patrickhuie19 patrickhuie19 approved these changes

@justinkaseman justinkaseman justinkaseman approved these changes

@vyzaldysanchez vyzaldysanchez Awaiting requested review from vyzaldysanchez vyzaldysanchez is a code owner automatically assigned from smartcontractkit/foundations

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agparadiso @patrickhuie19 @justinkaseman