Multiple offramps support according to CCIP minor version [NONEVM-1200] #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toblich
commented
Jan 24, 2025
Comment on lines
-320
to
-332
| #[derive(Accounts)] | ||
| pub struct UpdateSupportedChainsConfigCCIPRouter<'info> { | ||
| #[account( | ||
| mut, | ||
| seeds = [CONFIG_SEED], | ||
| bump, | ||
| constraint = valid_version(config.load()?.version, MAX_CONFIG_V) @ CcipRouterError::InvalidInputs, // validate state version | ||
| )] | ||
| pub config: AccountLoader<'info, Config>, | ||
| #[account(address = config.load()?.owner @ CcipRouterError::Unauthorized)] | ||
| pub authority: Signer<'info>, | ||
| pub system_program: Program<'info, System>, | ||
| } |
There was a problem hiding this comment.
This seemed to be dead code
toblich
commented
Jan 24, 2025
Comment on lines
+32
to
+33
| pub const DEST_CHAIN_SEED: &[u8] = b"dest_chain_state"; | ||
| pub const SOURCE_CHAIN_SEED: &[u8] = b"source_chain_state"; |
There was a problem hiding this comment.
I'm removing the state bit of the names here as they hold config & state. I left the seeds untouched to no affect offchain code that may already be using those values though. If you think it's ok to change the seed values and just notify people, I'll happily do it.
toblich
force-pushed
the
refactor/versioned-state
branch
from
d15f05f to
63fb48a
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR differentiates the offramp between CCIP minor versions, so that a message must be executed invoking the same offramp that it was committed in.
add_chain_selectorinto two methods, one for the source chain (versioned) and one for the dest chain (unversioned, as we can't change PDAs in the onramp transparently to the end user).ccip_versionparameterccip_versionin themTODOs (may be separate PRs to not make this one grow even more)