Added study distribution #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
dogversioning
force-pushed
the
mg/sns-fanning
branch
from
1fe6c8e to
92c0439
Compare
dogversioning
commented
Dec 17, 2024
mikix
approved these changes
Dec 26, 2024
| 200, | ||
| ), | ||
| ("invalid_study", "https://github.com/smart-on-fhir/invalid_study", 500), | ||
| ("non_cumulus_repo", "https://github.com/user/non_cumulus_repo", 500), |
There was a problem hiding this comment.
This line is trying to test that a ValueError is thrown when no smart-on-fhir string is detected, yeah? Can this test code distinguish from the case where the code does try to hit that URL but no responses mock has been set up for it?
There was a problem hiding this comment.
probably with some work.
this would be easier if we could use something other than the generic error handler, but security has requested these endpoints be extremely vague in their error reporting until the dashboard is deployed inside AWS.
dogversioning
force-pushed
the
mg/sns-fanning
branch
from
8f4ecaf to
7541a56
Compare
dogversioning
commented
Jan 6, 2025
mikix
approved these changes
Jan 6, 2025
dogversioning
force-pushed
the
mg/sns-fanning
branch
from
ff9cfad to
597a2f9
Compare
dogversioning
force-pushed
the
mg/sns-fanning
branch
from
597a2f9 to
628df18
Compare
mikix
reviewed
Jan 7, 2025
| parsed_url = urllib.parse.urlparse(config["url"]) | ||
| if ( | ||
| not parsed_url.netloc == "github.com" | ||
| or not parsed_url.path.startswith("/smart-on-fhir") |
There was a problem hiding this comment.
Should add a trailing slash, else the smart-on-fhir-for-realz org can send URLs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a mechanism for shipping prepared studies from github directly to sites, by adding a new lambda and an SNS queue with cross-account subscription permissions.