INCODE Application Areas data models

[feki-rihab]

I have added all the data models produced from the INCODE Application Areas (AA1, AA2, AA3, AA4)

Next steps:

1. Validating these data models
2. Generating the examples in the other formats
3. Generating the specification and readme files.

[albertoabellagarcia]

1. the examples directory starts lowercase. You have it starting capital
2. the png file is not requested
3. Description of the data model entity has to be longer
4. there are missing NGSI types in the description of the attributes (page 10 of contribution manual)
5. too many required attributes, however type which is mandatory is not there
6. If you have used a broker please include also the normalized example according to the contribution manual
   In general try to pass the testing process
   https://smartdatamodels.org/index.php/data-models-contribution-api/

[albertoabellagarcia]

if you need support please let me know or book a support session here

[feki-rihab]

I have made some changes in the latest commits to the data models of the different Application Areas (AA1 - AA2 - AA3 - AA4)

• the examples directory starts lowercase. You have it starting capital
• the png file is not requested
• Description of the data model entity has to be longer => I do not have enough information from the partners, I made my best effort to collect that data that we have now.
• there are missing NGSI types in the description of the attributes => Following the data provided I only can provide the example.json >>> would it be possible to generate the rest automatically via the scripts in the pysmartdatamodels or a service?
• too many required attributes, however type which is mandatory is not there >>> I added type as required
• If you have used a broker please include also the normalized example according to the contribution manual >>> The data provided does not reflect that it was collected via a Context Broker.

[albertoabellagarcia]

Please check the same errors you have in the first two models across the rest of them. And eventually try to validate first with the testing service before contributing
https://smartdatamodels.org/index.php/data-models-contribution-api/

thanks

[albertoabellagarcia]

same

[albertoabellagarcia]

0.0.1

[albertoabellagarcia]

I am approving the PR because I need to for fixing a problem. but the changes needs to be addressed anyway

[feki-rihab]

Thank you Alberto, I will check your comments and make the necessary changes that I can do. (I will still do it on this branch, so i will not delete it yet)

[feki-rihab]

All the comments are resolved (in a new pull request: #146)