Extend schemas for Dataset and DataService from 2.1.1 to 3.0.0 #9

flopezag · 2024-10-15T08:41:24Z

Aligned to 3.0.0
Correct some issues with the specification of DCAT-AP to transform links to Relationship
Fix the license values available
Update notes.yaml and README.md

… (WATERVERSE)

…ions (WATERVERSE)

…he subject

albertoabellagarcia

Feernando. please check the comments sent internally

bobeal · 2024-10-23T12:57:02Z

Hi,

What's the status of this PR? May I help in some way (since I'm working on this with @flopezag in the WATERVERSE project)?

…el.DCAT-AP into extend_schemas

albertoabellagarcia

Please attend the changes requested and pass the validator

albertoabellagarcia · 2024-11-25T17:58:38Z

DataService/examples/example-normalized.json

-      ]
-    }
+  "accessRights": {
+    "type": "Property",


example-normalized.json is the NGSIv2 normalized, therefore this payload is wrong. Why change the good one?

albertoabellagarcia · 2024-11-25T17:59:26Z

DataService/examples/example-normalized.jsonld

+    "type": "Property",
+    "value": [
+      {
+        "type": "ContactPoint",


I doubt that this is right.

in NGSI-LD, a value can be a JSON array, so this will work. But it would be better represented using a JsonProperty instead of a Property.

ok, I have to implement this jsonProperty in the testing process as well

DataService/examples/example-normalized.jsonld

albertoabellagarcia · 2024-11-25T18:02:22Z

DataService/notes.yaml

+notesFooter:
+  # CHANGELOG DCAT-AP <img align="right" src="/semic-icon-small.png" alt="SEMIC Core Vocabulary" />


comments are not allowed

albertoabellagarcia · 2024-11-25T18:03:59Z

DataService/schema.json

+          "description": "Property. Model:'http://www.w3.org/ns/dcat#contactPoint'. Contact information that can be used for sending comments about the Data Service. Cardinality: 0..n.",
+          "items": {
+            "type": "object",
+            "description": "Property. Model:'https://www.w3.org/ns/dcat#contactPoint'. Relevant contact information for the cataloged resource. Use of vCard is recommended (https://www.w3.org/TR/vcard-rdf/#d4e1819)."


Where are the properties of this object defined?

"properties": {
"email": {
"type": "string",
"description": "Property. To specify the electronic mail address for communication with the object the vCard represents"
"format": "email"
}
}}

Dataset/examples/example.jsonld

albertoabellagarcia · 2024-11-25T18:13:34Z

Dataset/examples/example.jsonld

  ],
-  "accrualPeriodicity": "weekly",
+  "geolocation": "True",


Dataset/examples/example.jsonld

albertoabellagarcia · 2024-11-25T18:14:34Z

Dataset/notes.yaml


 notesMiddle:
+
+notesFooter:
+  # CHANGELOG DCAT-AP <img align="right" src="/semic-icon-small.png" alt="SEMIC Core Vocabulary" />


not allowed comments of this type

albertoabellagarcia · 2024-11-25T18:16:10Z

Dataset/schema.json

+        "geolocation": {
+          "type": "string",
+          "description": "Property. Model:'https://schema.org/Boolean'. Defines if the data stream has geolocation (coordinates) in any of its attributes.",
+          "enum": ["True", "False"]


These are strings not booleans

bobeal · 2024-11-26T07:51:49Z

DataService/examples/example-normalized.jsonld

+    "type": "Property",
+    "value": [
+      {
+        "type": "ContactPoint",


in NGSI-LD, a value can be a JSON array, so this will work. But it would be better represented using a JsonProperty instead of a Property.

bobeal · 2024-11-26T07:54:31Z

DataService/examples/example-normalized.jsonld

+    "value": "https://raw.githubusercontent.com/smart-data-models/dataModel.DCAT-AP/refs/heads/master/DataService/schema.json"
+  },
+  "@context": [
+    "https://raw.githubusercontent.com/smart-data-models/dataModel.DCAT-AP/master/context.jsonld"


better use https://smart-data-models.github.io/dataModel.DCAT-AP/context.jsonld (files served from raw.githubusercontent.com have a text/plain content type, which is invalid as per the JSON-LD specification)

ok, no problem

Dataset/examples/example.jsonld

bobeal · 2024-11-26T08:06:57Z

Dataset/examples/example-normalized.jsonld

    "type": "Property",
-    "value": "two years"
+    "value": "True"
  },
  "hasVersion": {
    "type": "Property",


Relationship since it seems to target entities?

bobeal · 2024-11-26T08:07:03Z

Dataset/examples/example-normalized.jsonld

-      "",
-      ""
+      "urn:ngsi-ld:Dataset:id:ASDF:68185655",
+      "urn:ngsi-ld:Dataset:id:ASDF:78185655"
    ]
  },
  "identifier": {
    "type": "Property",


Relationship since it seems to target entities?

bobeal · 2024-11-26T08:07:52Z

Dataset/examples/example-normalized.jsonld

  "qualifiedAttribution": {
    "type": "Property",
    "value": [
-      ""
+      "Central born manage evidence data. Answer doctor visit ready physical fact. Quite allow however certain lose heart.",
+      "Home interesting range ever. Magazine the instead particularly. Late have collection."
    ]
  },
  "qualifiedRelation": {
    "type": "Property",


Relationship since it seems to target entities?

albertoabellagarcia · 2024-11-26T16:00:22Z

DataService/examples/example.jsonld

+      "fi": "Euroopan avoimen datan portaalin tietopalvelu"
+    }
+  },
+  "validationSchema": "https://raw.githubusercontent.com/smart-data-models/dataModel.DCAT-AP/refs/heads/master/DataService/schema.json",
  "@context": [


better use https://smart-data-models.github.io/dataModel.DCAT-AP/context.jsonld (files served from raw.githubusercontent.com have a text/plain content type, which is invalid as per the JSON-LD specification)

flopezag added 5 commits September 11, 2023 14:14

Update DCAT-AP:Dataset for the FAIR principles and MELODA5 dimensions…

095326d

… (WATERVERSE)

Update DCAT-AP:DataService for the FAIR principles and MELODA5 dimens…

9ab77d3

…ions (WATERVERSE)

Update to v3.0.0 and correction some issues from Waterverse

626680f

Update Dataset and DataService classes

8c67a2b

Update some examples problem and update notes.yaml and README.md of t…

bb96271

…he subject

flopezag requested a review from albertoabellagarcia October 15, 2024 08:41

flopezag and others added 3 commits October 15, 2024 10:57

Resolve conflicts to master

be9f4a6

Delete DataService/README.md

08d13f4

Delete README.md

b8f38f5

albertoabellagarcia requested changes Oct 17, 2024

View reviewed changes

Delete .gitignore

1c64c0a

flopezag added 18 commits November 6, 2024 22:04

Resolutio some PR comments

06a4ed7

Merge branch 'extend_schemas' of github.com:smart-data-models/dataMod…

bbd130b

…el.DCAT-AP into extend_schemas

Review of the examples and adding content to notes.yaml

00dcd96

Update DataService class and the jsonld examples

5abeec8

Update notes.yaml from Dataset and DataService classes

1781290

Update to resolve Data Models Testing tool

c3786b0

Update notes.yaml

9f08edc

Update data model schemas and add json examples

a1bc5a4

Change from modifiedAt to modified

17e3b29

Update notes

5a7ecd3

Update examples in Dataset

b0cdbbc

Update spatialResolution value in normalized json and jsonld

99ac771

Update Dataset data model

abc5318

Update DataService class

6e10bc5

Remove modifiedAt property from the examples

ab7d8d8

Update values of license property

4744e00

Update example-normalized.json

be722d5

Update example-normalized.json

7a215c2

albertoabellagarcia requested changes Nov 25, 2024

View reviewed changes

bobeal reviewed Nov 26, 2024

View reviewed changes

albertoabellagarcia reviewed Nov 26, 2024

View reviewed changes

flopezag and others added 2 commits December 6, 2024 19:11

Review PR comments about Dataset and DataService

cd11642

fix typo in example

ceaf7c3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extend schemas for Dataset and DataService from 2.1.1 to 3.0.0 #9

Extend schemas for Dataset and DataService from 2.1.1 to 3.0.0 #9

flopezag commented Oct 15, 2024

albertoabellagarcia left a comment

bobeal commented Oct 23, 2024

albertoabellagarcia left a comment

albertoabellagarcia Nov 25, 2024

albertoabellagarcia Nov 25, 2024

bobeal Nov 26, 2024

albertoabellagarcia Nov 26, 2024

albertoabellagarcia Nov 25, 2024

albertoabellagarcia Nov 25, 2024

albertoabellagarcia Nov 26, 2024

albertoabellagarcia Nov 25, 2024

albertoabellagarcia Nov 25, 2024

albertoabellagarcia Nov 25, 2024

bobeal Nov 26, 2024

bobeal Nov 26, 2024

albertoabellagarcia Nov 26, 2024

bobeal Nov 26, 2024

bobeal Nov 26, 2024

bobeal Nov 26, 2024

albertoabellagarcia Nov 26, 2024

		notesFooter:
		# CHANGELOG DCAT-AP <img align="right" src="/semic-icon-small.png" alt="SEMIC Core Vocabulary" />

Extend schemas for Dataset and DataService from 2.1.1 to 3.0.0 #9

Are you sure you want to change the base?

Extend schemas for Dataset and DataService from 2.1.1 to 3.0.0 #9

Conversation

flopezag commented Oct 15, 2024

albertoabellagarcia left a comment

Choose a reason for hiding this comment

bobeal commented Oct 23, 2024

albertoabellagarcia left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment