[Wallet] consolidating #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ico.funds.reception] fetchAddressState and plan
lambdina
force-pushed
the
wallet-consolidate
branch
from
719d786 to
f506062
Compare
nhenin
reviewed
Nov 19, 2021
| , validitySlotRangeMaybe = Nothing | ||
| , tokenSupplyChangesMaybe = Nothing | ||
| , ..} | ||
| <> ["--invalid-hereafter", show (synSlotAsInt + 600)]) |
There was a problem hiding this comment.
why are you adding ["--invalid-hereafter", show (synSlotAsInt + 600)]) ?
| @@ -129,7 +140,7 @@ instance ToCardanoCLIOptions TxOut where | |||
| [ "--tx-out" , coerce address <> " " <> (T.unpack . toCLI) value | |||
| , "--tx-out-datum-hash" , coerce datumHash] | |||
| toCardanoCLIOptions ToWallet {..} = | |||
| [ "--tx-out" , coerce address <> " " <> (T.unpack . toCLI) value] | |||
| [ "--tx-out" , coerce address <> "+" <> (T.unpack . toCLI) value] | |||
There was a problem hiding this comment.
you should not add a "+" here, the format is "address x lovelace + y policyhash.tokenName" , something like that
| return $ rmdups currencyList | ||
|
|
||
| askSelectUTxOByType :: (MonadIO m, MonadReader Environment m) => Wallet -> m (Maybe [UTxO]) |
There was a problem hiding this comment.
askUTxOByAssetClass :: (MonadIO m, MonadReader Environment m) => Wallet -> m (Maybe (NonEmpty UTxO))
| >>= \wallets -> do | ||
| printLn "Select the minter wallet : " | ||
| askToChooseAmongGivenWallets wallets | ||
| tokensChoosen <- askSelectUTxOByType wallet >>= whenNothingThrow NoFundsToBeRetrieved |
There was a problem hiding this comment.
whenNothingThrow NoTokensFound
| (txFolder, rawTx ) <- (\a-> (a,a <> "tx.raw")) <$> getFolderPath Transactions | ||
| aGivenTxOutRef <- txOutRef <$> (selectBiggestStrictlyADAsNotCollateral wallet >>= whenNothingThrow NoADAInWallet) | ||
|
|
||
| buildRaw "0" (toCardanoCLIOptions TxBuild |
There was a problem hiding this comment.
why are you using buildRaw here ?
nhenin
reviewed
Nov 19, 2021
nhenin
reviewed
Nov 19, 2021
| getCurrency :: UTxO -> (CurrencySymbol, TokenName) | ||
| getCurrency utxo = (currency, _tokenName) | ||
| where (currency, _tokenName, _) = getTokenFrom utxo |
There was a problem hiding this comment.
getTokenFrom should be changed
|
@devfull can we close this ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.