Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/96 97 issues #98

Merged
merged 11 commits into from
Sep 4, 2024
Merged

Feature/96 97 issues #98

merged 11 commits into from
Sep 4, 2024

Conversation

smarie
Copy link
Owner

@smarie smarie commented Sep 4, 2024

This Pull request fixes #96, fixes #97
Changes are in src/mkdocs_gallery/gen_single.py

I also had to update the CI workflows including nox sessions, for CI to run smoothly.

@smarie
Copy link
Owner Author

smarie commented Sep 4, 2024

@schlegelp could you checkout this branch, run pip install . while having your work environment activated, and let me know if it solves the two issues ? Indeed the test harness of this project is quite small so I prefer to double-check.
Thanks !

In the meantime I am trying to solve an issue of package versions compliance between mayavi, numpy and configobj
EDIT: done, all CI jobs pass. Waiting for your confirmation that this has the expected behaviour concerning metadata of the readme pages.

If you would like to propose something different, feel free to propose a code to replace what I did in src/mkdocs_gallery/gen_single.py

@smarie
Copy link
Owner Author

smarie commented Sep 4, 2024

I ended up modifying the built-in example gallery to include custom metadata, it seems to work.
waiting for CI to pass and then I'll release

@schlegelp
Copy link

schlegelp commented Sep 4, 2024

Left a comment and another request in #96!

@smarie smarie merged commit 9e8f966 into main Sep 4, 2024
13 checks passed
@smarie smarie deleted the feature/96_97_issues branch September 4, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dead link at the bottom of the generated gallery examples Defining page setup in README.md
2 participants