Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoji deprecation warning #104

Merged
merged 5 commits into from
Sep 30, 2024

Conversation

BalzaniEdoardo
Copy link
Contributor

This Pull request updates the emoji logic for mkdocs-material, fixes #103.

  • I completed the issue numbers (#xx) in the sentence above. The word "fixes" should remain in front of each issue
  • My PR is tagged as draft when I'm still working on it, and I remove the draft flag when it is ready for review.
  • I added one or several changelog.md entries in the appropriate "in progress" section (not the last release one)

b - My PR fixes some issues:

  • Each issue is well-described, well-labeled, and contains reproducible code examples.

@BalzaniEdoardo
Copy link
Contributor Author

Sorry about the tests failing, I didn't have python 3.7 installed locally.
I checked the python support of mkdocs-material, and they need python >=3.8. What should I do about this?

@BalzaniEdoardo
Copy link
Contributor Author

Thanks for the guidance!

@smarie smarie merged commit 0ae7dd7 into smarie:main Sep 30, 2024
13 checks passed
@smarie
Copy link
Owner

smarie commented Sep 30, 2024

Thanks a lot @BalzaniEdoardo !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emoji Logic Deprecation Warning
2 participants