Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making the conditions cleaner. #201

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Montana
Copy link

@Montana Montana commented Oct 21, 2024

Hello,

Making the conditions a bit cleaner for readability and modality.

The condition [[ "${tag_value:0:1}" == "v" ]] is equivalent to [[ ${last_half::1} == "v" ]], both checking if the first character is "v".

The condition [[ "${tag_value:0:1}" == "v" ]] is equivalent to [[ ${last_half::1} == "v" ]], both checking if the first character is "v".
@Montana Montana requested review from maraino and a team as code owners October 21, 2024 15:57
@CLAassistant
Copy link

CLAassistant commented Oct 21, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ dopey
❌ Montana
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Oct 21, 2024
@dopey dopey self-requested a review October 22, 2024 17:08
@dopey
Copy link
Contributor

dopey commented Oct 22, 2024

Hey @Montana 👋, thanks for submitting the issue!

This seems like a useful update! Would you mind signing our CLA so we can continue to triage, test, and merge this PR?

Cheers 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Waiting for discussion / prioritization by team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants