Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated to workable state #21

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Updated to workable state #21

wants to merge 2 commits into from

Conversation

J-Hunter-Hawke
Copy link
Collaborator

  • Updated version formatting
  • Bumped versions to latest
  • Installed CSI driver in cluster

@CLAassistant
Copy link

CLAassistant commented Jan 31, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

areed
areed reviewed Jan 31, 2023
View reviewed changes
aws/cluster.tf
@@ -198,6 +198,13 @@ resource "aws_iam_role_policy_attachment" "eks_node_group_3" {
role = aws_iam_role.eks_node_group.name
}

# New requirement to run the EBS CSI Driver
# which is a new requirement to mount persistent volumes
resource "aws_iam_role_policy_attachment" "eks_node_group_4" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be added to aws_eks_node_group.eks.depends_on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@areed areed areed left review comments

@phillram phillram Awaiting requested review from phillram

@lindambrown lindambrown Awaiting requested review from lindambrown

@andysmallstep andysmallstep Awaiting requested review from andysmallstep

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@J-Hunter-Hawke @CLAassistant @areed