Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --password-file to crypto jwe encrypt #1294

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eest
Copy link

@eest eest commented Oct 8, 2024

Name of feature:

Add --password-file to crypto jwe encrypt

Pain or issue this feature alleviates:

Makes it possible to run the command without prompts for input if e.g. running it from a script to modify the password of a user as described in https://smallstep.com/docs/step-ca/provisioners/#changing-a-jwk-provisioner-password. The flag also matches the already available flag for the decrypt command. Also the usage string for the decrypt command has been updated to mention decryption. This fix basically mirrors how things are done in decrypt.go.

Why is this important to the project (if not answered above):

Helpful for scripting with the step client.

Is there documentation on how to use this feature? If so, where?

The flag includes a usage string.

In what environments or workflows is this feature supported?

Any using step cli.

In what environments or workflows is this feature explicitly NOT supported (if any)?

N/A

Supporting links/other PRs/issues:

💔Thank you!

@CLAassistant
Copy link

CLAassistant commented Oct 8, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Oct 8, 2024
@eest eest force-pushed the crypto_jwe_encrypt_password branch from f355224 to e781ba8 Compare October 20, 2024 06:04
Matches the already existing flag for `crypto jwe decrypt`.

While here fix usage string for the existing flag since it deals with
decryption.
@eest eest force-pushed the crypto_jwe_encrypt_password branch from 2c5e509 to 2a20186 Compare November 9, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Waiting for discussion / prioritization by team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants