Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Docker images using goreleaser-pro instead of make #1230

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tashian
Copy link
Contributor

@tashian tashian commented Jul 10, 2024

Note: We need to wait for a release of GoReleaser Pro before we can merge this.

This PR builds bin/step using the same GoReleaser Pro workflow as in other parts of the CI system:

goreleaser build \
      --id default \
      --single-target \
      --auto-snapshot \
      --clean \
      --output bin/step

It should use the version number from the most recent tag.
The --auto-snapshot flag appends -next to the version number if the git repo is dirty.

The --single-target flag builds for the current GOOS, GOARCH, and GOARM only.

  • Test that Docker images build properly across different platforms
  • Do a prerelease build, to see the whole thing working properly

@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Jul 10, 2024
@tashian tashian requested a review from dopey July 10, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Waiting for discussion / prioritization by team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants