Only set the partition on a span if it's been set (#1101)

smallrye · Mar 15, 2021 · d468743 · d468743
1 parent 0cbd15f
commit d468743
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/...ve-messaging-kafka/src/main/java/io/smallrye/reactive/messaging/kafka/impl/KafkaSink.java b/...ve-messaging-kafka/src/main/java/io/smallrye/reactive/messaging/kafka/impl/KafkaSink.java
@@ -298,7 +298,9 @@ private void createOutgoingTrace(Message<?> message, String topic, int partition
             Scope scope = span.makeCurrent();
 
             // Set Span attributes
-            span.setAttribute("partition", partition);
+            if (partition != -1) {
+                span.setAttribute(SemanticAttributes.MESSAGING_KAFKA_PARTITION, partition);
+            }
             span.setAttribute(SemanticAttributes.MESSAGING_SYSTEM, "kafka");
             span.setAttribute(SemanticAttributes.MESSAGING_DESTINATION, topic);
             span.setAttribute(SemanticAttributes.MESSAGING_DESTINATION_KIND, "topic");