Use JsonProvider holder #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sberyozkin
approved these changes
Nov 14, 2024
|
Still interested in a micro release once this is in! |
|
Hi @gsmet I'll try to do it early next week, I need to fix 2 bugs, one with a matching Quarkus issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#836 removed JsonProvider instantiation from JsonUtils, but KeyUtils is still instantiating a new json provider every time that we load JWKs... this PR creates a JsonProviderHolder in the common lib, and reuses that in JsonUtils and KeyUtils so we remove all JsonProvider re-instantiation from the project.