Improvements #1084
Merged
Improvements #1084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `AsyncSupport` is never looked up from the `FaultToleranceContext`, so there's no need to put it there in the first place.
In addition to checking if the `Future` is already complete, this commit also checks if the `Future` is already cancelled. In both cases registering a completion callback is a waste of time.
Previously, when SmallRye Fault Tolerance's `InvocationContext` was renamed to `FaultToleranceContext`, some of the `interceptionContext` variables were renamed to `invocationContext` (now that there's no ambiguity). This commit finishes that rename.
…tage() The `Uni.subscribeAsCompletionStage()` method returns `CompletableFuture`, so calling `toCompletableFuture()` on it makes no sense.
This is because there are other `get()` methods, with parameters, whose purpose is completely different. Therefore, the zero-parameter version of `get()` is renamed back to `call()`, as it was before. This means that the `FaultToleranceContext` class can no longer implement `Supplier`, and we don't want it to implement `Callable` either. Fortunately, that has never been useful for anything, so this commit just drops it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AsyncSupportto theFaultToleranceContextCoroutineSupport.fromFuture()interceptionContexttoinvocationContexton remaining placestoCompletableFuture()afterUni.subscribeAsCompletionStage()Guard/TypedGuardbeanssuspendfunctions to@ApplyGuardFaultToleranceContext.get()tocall()