Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability to disable individual metric providers #1079

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

Ladicek
Copy link
Contributor

@Ladicek Ladicek commented Nov 19, 2024

Resolves #1078

@Ladicek Ladicek added this to the 6.7.0 milestone Nov 19, 2024
@rhusar
Copy link
Contributor

rhusar commented Nov 19, 2024

Let me take this for a quick spin.

@Ladicek
Copy link
Contributor Author

Ladicek commented Nov 19, 2024

Please report back; I'll keep this open until then.

Copy link
Contributor

@rhusar rhusar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried a few things and this seems to worked exactly as I wanted to. Last piece of the OpenTelemetry puzzle is in place!

Also reviewed the code and LGTM.

@Ladicek Ladicek merged commit 72293db into smallrye:main Nov 19, 2024
13 checks passed
@Ladicek Ladicek deleted the disable-metric-providers branch November 19, 2024 14:09
@rhusar
Copy link
Contributor

rhusar commented Nov 19, 2024

As discussed, will be backported to 6.6.x.

@Ladicek
Copy link
Contributor Author

Ladicek commented Nov 19, 2024

The PR #1080 backports this to 6.6. I'll release 6.6.3 later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exposing MP Config properties for individually disabling metrics providers
2 participants