Avoid using string concatenation to forge impl name #1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also avoid using hashCode(). My understanding is that it was used to make sure the name wouldn't clash but I think it's better to use an approach to what CDI did.
gsmet
commented
Aug 26, 2024
Comment on lines
+130
to
+131
| Class<?> implementationClass = type.getClassLoader() | ||
| .loadClass(ConfigMappingInterface.getImplementationClassName(type)); |
There was a problem hiding this comment.
BTW to clarify, the point was to fix the issue here. But... I broke the tests by doing so because ConfigMappingInterface had the same code. So I made sure they would share the code now.
|
If I remember correctly, we had the We later rewrote that piece to use |
radcortez
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also avoid using hashCode(). My understanding is that it was used to make sure the name wouldn't clash but I think it's better to use an approach to what we did for other technical classes.
This is related to the discussion in quarkusio/quarkus#42506 .
And in particular to this: