Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Use \sprintf in buildApiUrl #90

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Enhancement: Use \sprintf in buildApiUrl #90

merged 1 commit into from
Sep 12, 2024

Conversation

OskarStark
Copy link
Contributor

No description provided.

@OskarStark OskarStark force-pushed the feature/sprintf-for-api-url branch from 4c99eb5 to e31960c Compare September 3, 2024 07:25
@slunak
Copy link
Owner

slunak commented Sep 3, 2024 •
edited
Loading

GlancesClient is missing here. - my fault, didnt see it was actually there. (edited)
See also maybe there are more places where we can use \sprintf

@OskarStark OskarStark force-pushed the feature/sprintf-for-api-url branch from e31960c to cb51ffd Compare September 3, 2024 11:49
@OskarStark
Copy link
Contributor Author

See also maybe there are more places where we can use \sprintf

Do you have some places in mind?

slunak
slunak approved these changes Sep 12, 2024
View reviewed changes
Copy link
Owner

@slunak slunak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@slunak slunak merged commit 0e5a32c into slunak:master Sep 12, 2024
6 checks passed
@OskarStark OskarStark deleted the feature/sprintf-for-api-url branch September 12, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slunak slunak slunak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OskarStark @slunak