Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rector vs CS #78

Closed
wants to merge 2 commits into from
Closed

Rector vs CS #78

wants to merge 2 commits into from

Conversation

slunak
Copy link
Owner

@slunak slunak commented Sep 1, 2024

Looks like rector and cs conflict... see commits @OskarStark

@OskarStark
Copy link
Contributor

Will have a look tomorrow

Vitexus
Vitexus approved these changes Sep 1, 2024
View reviewed changes
Copy link
Contributor

@Vitexus Vitexus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
there is nothing here to break

@OskarStark
Copy link
Contributor

CleanShot 2024-09-02 at 08 04 15@2x

This is what we want, right?

@slunak
Copy link
Owner Author

slunak commented Sep 2, 2024 •
edited
Loading

This is what we want, right?

I dont mind either, depending what is the standard in PHP, up to you to decide basically :)

@OskarStark
Copy link
Contributor

Yes, so this is what we want

@OskarStark OskarStark mentioned this pull request Sep 2, 2024
Merged
@slunak slunak closed this in #79 Sep 2, 2024
@slunak slunak closed this in 088387d Sep 2, 2024
@slunak slunak deleted the fix-rector branch September 2, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vitexus Vitexus Vitexus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slunak @OskarStark @Vitexus