Enhancement: Ensure Recipient is set for specific actions #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
force-pushed
the
feature/ensure-recipient
branch
from
0bd1cff to
cd2fd44
Compare
Vitexus
approved these changes
Sep 1, 2024
|
Ready to merge from my side |
OskarStark
force-pushed
the
feature/ensure-recipient
branch
2 times, most recently
from
959a0ce to
7825f55
Compare
|
Rebased |
|
Would you mind to merge master into this one please? |
OskarStark
force-pushed
the
feature/ensure-recipient
branch
from
7825f55 to
3e81c9d
Compare
OskarStark
force-pushed
the
feature/ensure-recipient
branch
from
3e81c9d to
98f8a19
Compare
|
I rebased |
slunak
reviewed
Sep 2, 2024
tests/Client/GroupsClientTest.php
Outdated
| @@ -34,69 +34,104 @@ public function testCanBeConstructed(): void | |||
| $this->assertInstanceOf(GroupsClient::class, $client); | |||
| } | |||
|
|
|||
| public function testBuildApiUrl(): void | |||
| /** | |||
| * @dataProvider buildApiUrlProvider | |||
There was a problem hiding this comment.
Can we use attributes? Because of
1) Metadata found in doc-comment for method Client\GroupsClientTest::testBuildApiUrl(). Metadata in doc-comments is deprecated and will no longer be supported in PHPUnit 12. Update your test code to use attributes instead.
There was a problem hiding this comment.
slunak
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GroupsClient