Enhancement: Add email to @author tags
#59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Vitexus if you post your mail here, I can add it as well |
Ah! You are from SensioLabs ... it explain it all :D |
|
Done |
@slunak Looking forward for release :) |
|
I am actually thinking to remove this at all... and instead create some sort of list of contributors or simply link here https://github.com/slunak/pushover-php/graphs/contributors. What do you think @OskarStark ? |
|
Managing a manual list of contributors is cumbersome, while removing yours seems ok to me, I would allow other contributors to put |
It is a good practice
OskarStark
force-pushed
the
feature/email
branch
from
82c40bc to
34fda6e
Compare
OskarStark
changed the title
@author tags@author tags
|
How is your decision here? |
Merging, thank you! |
slunak
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a good practice