CS-Fixer: Enable nullable_type_declaration_for_default_null_value
#43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
commented
Aug 22, 2024
| @@ -63,7 +63,7 @@ public function buildApiUrl() | |||
| return Curl::API_BASE_URL.'/'.Curl::API_VERSION.'/groups/'.$this->group->getKey().'/'.$this->action.'.json?token='.$this->group->getApplication()->getToken(); | |||
| } | |||
|
|
|||
| public function buildCurlPostFields(Recipient $recipient = null): array | |||
| public function buildCurlPostFields(?Recipient $recipient = null): array | |||
| { | |||
| $curlPostFields = [ | |||
| 'token' => $this->group->getApplication()->getToken(), | |||
There was a problem hiding this comment.
just spotted, that in line 78, $recipient can be null, right?
slunak
approved these changes
Aug 23, 2024
|
This is the last PR for cs fixer? I wonder, is it possible to add a check to github actions to detect that cs fixer was not run and make sure it is run? Is it a good practice? I may be wrong, but depending on PHP version changes cs fixer may apply different changes? |
|
I will create one afterwards |
|
You can merge this first please |
|
Sure, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.