CS-Fixer: Enable phpdoc_to_property_type
#38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
commented
Aug 20, 2024
| @@ -84,12 +84,11 @@ | |||
| ], | |||
| ], | |||
| 'yoda_style' => false, | |||
| 'php_unit_test_case_static_method_calls' => false, | |||
There was a problem hiding this comment.
I would keep this rule, or shall we switch to:
- $this->assertSame(
+ self::assertSame(
There was a problem hiding this comment.
Agree, I like $this->assertSame( more too.
OskarStark
force-pushed
the
feature/cs-fixes-4
branch
10 times, most recently
from
5a4b283 to
abe86df
Compare
OskarStark
force-pushed
the
feature/cs-fixes-4
branch
from
abe86df to
54b2c11
Compare
|
Ready to merge |
|
Let me just fix test |
slunak
approved these changes
Aug 21, 2024
|
Sorry was too late yesterday and didn't spot them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.