Enhancement: Recipient rework
#102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @OskarStark Few points:
|
OskarStark
commented
Sep 24, 2024
composer.json
Outdated
| @@ -20,7 +20,8 @@ | |||
| "require": { | |||
| "php": ">=8.2", | |||
| "ext-curl": "*", | |||
| "ext-json": "*" | |||
| "ext-json": "*", | |||
| "symfony/deprecation-contracts": "^3.5" | |||
There was a problem hiding this comment.
forgot to add this @slunak
There was a problem hiding this comment.
I actually would like to avoid any dependencies. I would be ok to use point 3 above.
There was a problem hiding this comment.
Maybe I come back later here, feel free to take over, I am a bit busy at the moment. sorry
There was a problem hiding this comment.
@OskarStark I have removed the dependency. I wonder, if trigger_error should be silenced though?
|
Should be good now |
|
Ready to merge I guess |
slunak
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.